Skip to content

[quattro] Pause shell plugin loads around package updates - #16900

Open
taxin-404 wants to merge 12 commits into
omacom:quattrofrom
taxin-404:fix/shell-update-reload-guard
Open

taxin-404 wants to merge 12 commits into
omacom:quattrofrom
taxin-404:fix/shell-update-reload-guard

Conversation

@taxin-404

@taxin-404 taxin-404 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Upgrading while the old shell is running hot-loads new plugin QML into the old engine. The running shell watches the package-owned config/omarchy/shell.json; the upgrade replaces that file with a list that adds omarchy.elsewhen and dock, and the old engine applies it mid-transaction. Those plugins compile QML that references rc1-only ShellIpc, so the shell reports ShellIpc is not a type and keybindings stay dead until a restart.

#16880 fixes a separate Qt QML cache-coherence race and explicitly leaves transient errors in a running engine during replacement out of scope. This change closes that window; the two are complementary.

Change

  • Read the package-owned default config/omarchy/shell.json once at startup. Only ~/.config/omarchy/shell.json keeps live reloading.
  • Add shell pausePlugins: a running shell stops mounting new plugin components and answers ok, letting a guard distinguish a shell that supports pausing from an old one. Every plugin load path honors the pause.
  • Add PreTransaction/PostTransaction ALPM hooks that pause plugin loads before package files are replaced and restart the shell after. A shell too old to pause is stopped cleanly. A locked session is left running, because stopping the lock client would strand the user.
  • Enumerate Quickshell instances as the session owner. The ALPM hook runs as root, and running quickshell list as root read root's home and could leave root-owned cache/log files outside the session.
  • Record the pause state before pausing or stopping, and skip the action if the record cannot be written. Previously a failed state write meant PostTransaction had nothing to resume and the shell stayed paused.
  • Recover a failed transaction in bin/omarchy-update-pacman, the shared transaction path for omarchy update and omarchy-refresh-pacman (and so omarchy-channel-set). Pacman does not run PostTransaction hooks when a transaction fails, so the helper probes the root-owned, world-readable state as the caller and resumes under the authorization it already used. omarchy update keeps its EXIT-trap recovery as a second safety net. A restart refused while locked keeps its state for a later restart or transaction.
  • Report a missing IPC target or function with a rate-limited notification from omarchy-shell instead of leaving a keybinding silently dead. Quiet probes stay silent and the IPC result is unchanged.

The hooks are inert without the packaging install in omacom/omarchy-pkgs#1755.

Limitation

Pacman reads hooks before a transaction, so this cannot protect the upgrade that installs them. The shell restart at the end of omarchy update covers that first transition.

omarchy-channel-set's final package swap still calls pacman directly (it may run against a tree that predates this helper). If that swap fails, the pause survives until the next transaction through omarchy-update-pacman, which the failure message tells the user to rerun.

Verification

All of these pass on the branch:

test/shell.d/shell-config-watch-test.sh
test/shell.d/shell-plugin-pause-test.sh
test/shell.d/shell-reload-guard-test.sh
test/shell.d/shell-missing-target-test.sh
test/shell.d/shell-ipc-test.sh
test/shell.d/plugins-test.sh
test/shell.d/bin-style-test.sh
test/shell.d/restart-shell-test.sh
test/shell.d/update-restart-phases-test.sh
test/shell.d/update-pacman-test.sh
test/shell.d/update-pacman-guard-test.sh
test/shell.d/update-hook-security-test.sh
test/shell.d/update-sequence-test.sh
test/shell.d/update-hangup-test.sh
test/shell.d/update-lock-test.sh
test/shell.d/update-user-path-test.sh
test/shell.d/hyprland-reload-guard-test.sh
test/shell.d/i18n-test.sh
test/shell.d/channel-test.sh
test/shell.d/channel-switch-test.sh
test/shell.d/channel-stale-dev-build-test.sh
test/shell.d/region-refresh-boundary-test.sh
test/shell.d/pacman-templates-test.sh
test/shell.d/security-entrypoint-symlink-test.sh
test/shell.d/security-source-root-test.sh
./test/cli

Also bash -n, git diff --check, and shellcheck 0.11 on the touched scripts (no new findings; the one remaining SC2010 in bin/omarchy-shell is pre-existing upstream code).

config-test.sh passes locally when OMARCHY_PKGS_PATH points at the omarchy-pkgs branch from #1755. In CI it checks out omarchy-pkgs master, which does not ship the two hook files yet, so the required test job stays red until #1755 merges:

omarchy PKGBUILD does not install default/libalpm/hooks/20-omarchy-shell-reload-pause.hook
omarchy PKGBUILD does not install default/libalpm/hooks/80-omarchy-shell-reload-resume.hook

That is the one expected failure in the full VM suite (428 of 429 test files pass).

@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 3/5

[Medium impact] The changes affect Omarchy desktop shells during package updates and calls to missing shell actions.

The PR needs fixes before merging: recovery can restart shells during another transaction, and a restart can leave another desktop session without its shell.

Findings

  1. P1 Recovery releases another transaction's pause ▶
  2. P1 Restart stops other desktop sessions ▶
  3. P2 Tests check text, not behavior ▶
  4. P2 New paragraphs break formatting rules ▶

Summary

This PR pauses shell plugin loads around package replacement and restarts affected shells afterward.

  • Package updates pause plugin loads and restart the shell afterward.
  • The shell reads packaged defaults only when it starts.
  • Missing shell actions now show a rate-limited notification.

Diagram

sequenceDiagram
  participant Pacman
  participant Guard
  participant Shell
  participant Restart as Restart helper
  Pacman->>Guard: PreTransaction pause
  Guard->>Shell: pausePlugins
  Shell-->>Guard: ok
  Pacman->>Pacman: Replace package files
  Pacman->>Guard: PostTransaction resume
  Note over Guard: Package wrapper also calls resume after failure
  Guard->>Restart: Restart each recorded session
  Restart->>Shell: Stop matching shells and launch replacement
Loading

Reviews (8) · Last reviewed commit: "Resume a paused shell when the pacman tr..." · Reviewed by Greptile

Comment thread bin/omarchy-shell Resolved
Comment thread bin/omarchy-shell-reload-guard Resolved
Comment thread test/shell.d/shell-plugin-pause-test.sh Outdated
Comment on lines +34 to +38
const body = functionBody(name)
assert(body.length > 0, `${name} is defined`)
assert(
/pluginsPaused/.test(body),
`${name} refuses to load plugin code while plugin loads are paused`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Tests check text, not behavior

These assertions only check whether function bodies contain pluginsPaused. They pass even if the check is unreachable or has the wrong effect. AGENTS.md explicitly says, “Don't restate the implementation,” including grepping source for newly added strings. Replace these source checks with behavior tests before merging. The same requirement applies to shell-config-watch-test.sh.

File Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread docs/update-process.md
Comment on lines +117 to +124
A second pair of hooks protects the shell while `/usr/share/omarchy/shell/**`
is replaced. The pre-transaction hook runs `omarchy-shell-reload-guard pause`,
which asks each running shell to stop loading plugin QML. A shell that predates
that IPC method is stopped cleanly instead, unless the session is locked:
stopping a live lock client would strand the session behind Hyprland's
failsafe. The post-transaction hook restarts the shell in each session the
guard touched, so the new tree is loaded by a fresh engine rather than hot-
reloaded into the old one.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 New paragraphs break formatting rules

The new paragraphs break lines within sentences. AGENTS.md requires full lines in Markdown, with breaks only at headings, list items, and other structural boundaries. Join each paragraph onto one line here and in the new paragraphs in omarchy-shell.md. This repository requirement must be satisfied before merging.

File Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for this, @taxin-404. This pull request has been classified, not yet reviewed or tested: no code from it has run, and no labels were added.

The classification is unsettled. Two models classified it separately, at head 0396409. Claude Opus 5.5 read it as a bug fix for #16126, where a running shell hot-loads the new plugin list mid-upgrade and shell-routed keybindings go dead until a restart. Codex Medium read it as an enhancement. The diff supports both readings: alongside the fix (reading the packaged shell.json once at startup, and pausing plugin loads during the transaction) it adds things that are new behaviour, namely a shell pausePlugins IPC method, a pair of ALPM hooks with a new omarchy-shell-reload-guard command, and a rate-limited desktop notification from omarchy-shell whenever an IPC target or function is missing. That last change applies to every missing-target call, not only during updates.

Next step is the maintainer's: deciding whether this is a fix to verify, or new behaviour, and whether the missing-action notification should be split into its own pull request. Once that's settled it will be reviewed and run on a test machine like any other fix.

@taxin-404

Copy link
Copy Markdown
Contributor Author

Rebased onto current quattro to clear the merge conflict that had marked this CONFLICTING (merge base was 177 commits behind).

The only conflict was in bin/omarchy-update. quattro has since removed the omarchy-security-functions entrypoint from that script, so the old if ! end_update_authorization; then ... omarchy_security_exit_with_revoked_sudo 1; fi block no longer applies. The resolution keeps the new bare end_update_authorization call and runs the failed-transaction resume ahead of it, still under the update's sudo authorization:

if guard=$(command -v omarchy-shell-reload-guard); then
  if sudo -n "$guard" paused >/dev/null 2>&1; then
    sudo -n "$guard" resume >/dev/null 2>&1 ||
      echo "Could not resume the shell after the update; restart it to load new plugins." >&2
  fi
fi
end_update_authorization

sudo -n matches the keepalive's style in the current script instead of the old /usr/bin/sudo. The five commits are otherwise unchanged; bin/omarchy-shell, shell/shell.qml, and the hooks rebased cleanly.

Local runs of test/shell.d/shell-reload-guard-test.sh, shell-config-watch-test.sh, shell-missing-target-test.sh, shell-plugin-pause-test.sh, and config-test.sh all pass against the rebased tree.

Comment thread shell/shell.qml Resolved
Comment thread bin/omarchy-shell-reload-guard Resolved
Comment thread bin/omarchy-update Resolved
Comment thread bin/omarchy-shell-reload-guard Resolved
Comment thread bin/omarchy-shell Resolved
@taxin-404

taxin-404 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Pushed a follow-up. The re-run now leaves a single failing file, config-test.sh; bin-style-test.sh and update-hook-security-test.sh are green.

What changed:

  • bin-style-test.sh — bin/omarchy-shell and bin/omarchy-update used a raw command -v, which the bin style test rejects. Both now use omarchy-cmd-present.
  • update-hook-security-test.sh — the failed-transaction resume probed the guard with sudo -n ... paused, adding a privileged call after the AUR step and breaking the "one authorization" invariant that test asserts. The guard's state holds no secrets, so the probe now runs unprivileged (the guard makes its state directory listable) and sudo -n ... resume only runs when a pause is actually recorded.

The remaining config-test.sh failure is omarchy-pkgs checkout lag: CI checks out omacom/omarchy-pkgs master, which does not install the two shell reload hooks yet.

omarchy PKGBUILD does not install default/libalpm/hooks/20-omarchy-shell-reload-pause.hook -> /usr/share/libalpm/hooks/20-omarchy-shell-reload-pause.hook
omarchy PKGBUILD does not install default/libalpm/hooks/80-omarchy-shell-reload-resume.hook -> /usr/share/libalpm/hooks/80-omarchy-shell-reload-resume.hook

I checked how this test handled the identical situation before. When 10-omarchy-hyprland-reload-pause.hook was added, the same source commit added both the hook files and their alpm_hooks entries in config-test.sh (f79a231); the omarchy PKGBUILD already installed 00-omarchy-update-guard.hook and the Hyprland pair from the packaging repo. config-test.sh deliberately tracks the source tree and cross-checks it against the packaging checkout, so the two land in separate repos by design.

I'm therefore keeping the alpm_hooks entries here rather than pulling them to make this PR green standalone: the failure is a real source/packaging dependency, and hiding it would let this merge without the packaging side that actually installs the hooks. config-test.sh clears here as soon as omacom/omarchy-pkgs#1755 merges. With that PR applied, config-test.sh passes locally, so the hook list itself is correct.

@taxin-404

taxin-404 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Pushed another round resolving the localized Greptile findings from this review. bin-style-test.sh, update-hook-security-test.sh, shell-reload-guard-test.sh, and shell-missing-target-test.sh pass locally.

Fixed:

  • bin/omarchy-shell — direct helper call. notify_missing no longer guards omarchy-notification-send with omarchy-cmd-present; AGENTS.md requires default-package commands to be called directly.
  • bin/omarchy-shell — shared /tmp fallback. The stamp directory is now created and then checked with [[ -O ... && ! -L ... ]], and a stamp path that is a symlink is refused. A planted symlink in the shared fallback can no longer redirect the timestamp write. Regression tests in shell-ipc-test.sh.
  • bin/omarchy-shell-reload-guard — empty fields. Records are split with cut instead of read, so an empty WAYLAND_DISPLAY/HYPRLAND_INSTANCE_SIGNATURE field no longer collapses the tabs and shifts action away, which would have dropped a still-running paused shell without restarting it. Regression test in shell-reload-guard-test.sh.
  • bin/omarchy-shell-reload-guard — undetermined lock state. session_locked now treats the probe's exit 2 (hyprctl failed) as locked, so only a definite "unlocked" allows stopping a shell. Regression test.
  • bin/omarchy-shell-reload-guard — positive identity. pause_instance now requires a non-empty OMARCHY_PATH that matches the config's own tree, so a foreign Quickshell config at shell/shell.qml is left alone.
  • shell/shell.qml — bar during a pause. activeBarId is frozen to the current bar while pluginsPaused, so editing shell.json or running omarchy-bar use during a transaction can no longer instantiate bar QML from the tree being replaced.
  • test/shell.d — no split suites. Per AGENTS.md, tests for an existing area extend that area's file: the omarchy-shell notification checks moved into shell-ipc-test.sh, the shell.json watch checks into config-test.sh, and the plugin-pause checks into plugins-test.sh. The separate shell-missing-target-test.sh, shell-config-watch-test.sh, and shell-plugin-pause-test.sh files are gone.

Leaving for a maintainer call:

  • Recovery is only wired into omarchy update. omarchy-refresh-pacman and omarchy-channel-set also run pacman through the hidden omarchy-update-pacman, and a failed transaction there has no resume step either. A shared recovery belongs in the common transaction path, which is a design choice rather than a local fix.
  • Source-text assertions. The shell.json watch checks and the plugin-pause checks assert on shell.qml source, now inside config-test.sh and plugins-test.sh. Making them behavioral needs a live Quickshell instance; happy to do that if that is the direction.
  • Markdown wrapping. docs/update-process.md and docs/omarchy-shell.md are hard-wrapped throughout, so the new paragraphs match the surrounding text.

config-test.sh remains red only for the omarchy-pkgs hook lag described above.

Comment thread test/shell.d/shell-config-watch-test.sh Resolved
@taxin-404

Copy link
Copy Markdown
Contributor Author

Latest head is 3c2c7bc. Greptile's "related tests are split" finding is resolved: the shell.json watch checks moved into config-test.sh, the plugin-pause checks into plugins-test.sh, and the omarchy-shell notification checks into shell-ipc-test.sh, so no new *-test.sh files remain.

Local runs: shell-ipc-test.sh, plugins-test.sh, shell-reload-guard-test.sh, bin-style-test.sh, update-hook-security-test.sh all pass. CI leaves config-test.sh as the only failure, still just the two 20-/80-omarchy-shell-reload-*.hook lines from the omarchy-pkgs lag; with omacom/omarchy-pkgs#1755 applied it passes.

The default shell.json lives in /usr/share/omarchy and changes only when a
package update replaces it. Watching it made a running shell apply the new
plugin list during the transaction, so the old engine lazily loaded new plugin
QML that referenced types it did not have (omacom#16126).

Keep live reload for the user's own shell.json; the update restarts the shell
after the package transaction.
taxin-404 added a commit to taxin-404/omarchy-pkgs that referenced this pull request Nov 17, 2026
The omarchy source now provides PreTransaction/PostTransaction hooks that
pause shell plugin loads and restart the shell around package updates.
Install them from both the stable and dev packages so they are not inert,
and include them in the synthetic source tree that
tests/passwordless-package-files.sh builds.

Both installs are conditional on the pinned source shipping the hooks.
Check for both files, not just the pause hook, so a source with half the
pair cannot install a pause hook whose resume never arrives. omarchy-dev
currently pins 79dcccfe5, and stable pins v4.0.6; neither contains the
source change yet, so an unconditional install would fail the build. The
hooks become active when those pins advance. The packaging test now
covers a source that ships the hooks and one that predates them, and
still asserts the two packages share no path.

The companion source change is omacom/omarchy#16900.

Verification: tests/passwordless-package-files.sh passes for x86_64 and
aarch64.
An upgrade replaces the plugin tree while the old shell still watches it, and
the old engine can lazily compile new plugin QML that references types it does
not have (omacom#16126). Expose shell pausePlugins and refuse plugin loads from every
path that can create them: reloads, registry syncs, services, panels, widgets,
and summons.

Already-loaded panels keep working; a summon that would mount a new one is
declined until the update restarts the shell.
The omarchy package replaces /usr/share/omarchy/shell while the old shell is
running. A PreTransaction hook now asks each running shell to pause plugin
loads; shells that predate that IPC are stopped cleanly, unless the session is
locked, where stopping the lock client would strand the user. A PostTransaction
hook restarts the shell in every session the guard touched, so the new tree is
loaded by a fresh engine.

Hooks are read before the transaction, so this cannot protect the upgrade that
installs it; the update's existing shell restart covers that first transition.
A shell left on the old package during an update does not know the newly
installed plugin, so the IPC call fails with 'Target not found.' or 'Function
not found.' and the keybinding silently does nothing. A non-quiet call now
raises one desktop notification per target and method every five minutes;
quiet probes, argument errors, and a stopped shell stay silent. The
notification is sent in the background and never changes the IPC result.
A failed pacman transaction never runs PostTransaction hooks, so resume the
paused shell from the update command's exit path through its existing sudo
authorization. A restart refused while the session is locked keeps its state
for a later attempt instead of losing track of the paused shell.

Only pause a shell whose own OMARCHY_PATH names the tree it runs from, so
another Quickshell config that happens to live at shell/shell.qml is left
alone, and give the guard's user commands a fixed PATH.
bin-style-test rejects a raw `command -v` in bin/, and the update's cleanup
probed the guard through sudo, which broke the single-authorization
invariant update-hook-security-test enforces. Use `omarchy-cmd-present`
instead, probe the (world-readable) guard state without privilege, and keep
the state directory listable so an unprivileged probe can read it.
bin/omarchy-shell ships in the default package set, so the helpers it
uses are runtime invariants: call omarchy-notification-send directly
instead of guarding it with omarchy-cmd-present.
Address the Greptile findings that are real and localized:

- Treat the lock probe's undetermined exit 2 as locked, so a shell that
  might own the lock screen is never stopped on an unresponsive probe.
- Read the guard's records with cut so an empty WAYLAND_DISPLAY or
  HYPRLAND_INSTANCE_SIGNATURE field does not shift action away and leave
  a still-running paused shell paused after the transaction.
- Require a positive OMARCHY_PATH match before pausing, so a foreign
  Quickshell config that also lives at shell/shell.qml is left alone.
- Write the missing-action stamp only into a directory this user owns,
  and never through a planted symlink in the shared /tmp fallback.
- Freeze the bar while plugin loads are paused, so a shell.json edit or
  omarchy-bar use mid-transaction cannot instantiate bar QML from the
  tree being replaced.
AGENTS.md asks a test for an existing command to extend that command's
file rather than add a new *-test.sh. The missing-action notification
checks are about omarchy-shell, which shell-ipc-test.sh already covers,
so they move there and shell-missing-target-test.sh goes away.
AGENTS.md asks a test for an existing area to extend that area's file
rather than add a new *-test.sh. The shell.json watch checks move into
config-test.sh, and the plugin-pause checks join plugins-test.sh, so
shell-config-watch-test.sh and shell-plugin-pause-test.sh go away.
Two review findings on the reload guard:

- `quickshell list` ran from the ALPM hook as root, so it read root's home
  and could create root-owned cache/log files outside the session. Run it
  through `as_user` like every other call into the session, and resolve the
  owning user and home from the runtime directory's uid.
- State was written only after the shell had been paused or stopped. If the
  write failed, PostTransaction had nothing to resume and the shell stayed
  paused forever. Write the record before the action, skip the action when
  the record cannot be written, and remove the record again when the action
  fails or is intentionally skipped (locked session).

The same state record is rewritten as `stopped` before a kill so resume
restarts a stopped shell instead of treating it as a running paused one.
A failed transaction never reaches its PostTransaction hook, so the shell
stayed paused. `omarchy update` already recovered in its EXIT trap, but
`omarchy-refresh-pacman` runs its own transaction and had no recovery, and
`omarchy-channel-set` goes through it.

Move the recovery into `bin/omarchy-update-pacman`, the shared transaction
path, and keep the command's exit status. The `paused` probe is
unprivileged because the state directory is world-readable; resume runs
under the authorization the helper already used.
@taxin-404
taxin-404 force-pushed the fix/shell-update-reload-guard branch from 3c2c7bc to 79b5059 Compare November 17, 2026 15:55
@taxin-404

Copy link
Copy Markdown
Contributor Author

Rebased onto current quattro (one conflict in shell/shell.qml: the newer localPluginNeedsReload property and this PR's pluginsPaused now coexist) and added two follow-ups from the review:

  1. The guard enumerates as the session user. instances_json ran quickshell list from the ALPM hook, which is root. It now resolves the uid's user/home and goes through the same as_user wrapper as every other call into the session.
  2. State is written before the action. pause_instance now writes the record first, skips pausing/stopping when the write fails, and removes the record when the action fails or is skipped for a locked session. Before this, a failed write left a paused shell that PostTransaction would never find.
  3. Failed-transaction recovery moved into bin/omarchy-update-pacman. omarchy update already recovered in its EXIT trap, but omarchy-refresh-pacman runs its own transaction. The shared helper now probes the state after pacman exits and resumes under the authorization it used, then exits with pacman's status. omarchy update keeps its trap as a second net.

config-test.sh is green now that the rebased branch contains the hook files; the packaging half stays inert until omacom/omarchy-pkgs#1755 lands. Full test list and results are in the updated description.

Comment thread bin/omarchy-update-pacman
Comment on lines +34 to +36
if omarchy-cmd-present omarchy-shell-reload-guard; then
if omarchy-shell-reload-guard paused >/dev/null 2>&1; then
sudo -n omarchy-shell-reload-guard resume >/dev/null 2>&1 ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Recovery releases another transaction's pause

While one update holds pacman's lock and replaces shell files, a second omarchy-refresh-pacman can fail because that lock is held. This recovery then calls the global resume, which restarts every recorded shell and removes its pause state while the first transaction is still running. The shell can load files that are still being replaced.

Tie recovery to the transaction that created the pause, and do not resume while another transaction is active. The same global recovery in omarchy-update needs that protection.

Knowledge Base Used: Update orchestration and system maintenance

Comment on lines +320 to +324
if as_user "$uid" "$runtime_dir" "$home" "$user" env \
OMARCHY_PATH="$omarchy_path" \
WAYLAND_DISPLAY="$display" \
HYPRLAND_INSTANCE_SIGNATURE="$signature" \
"$restart_bin" >/dev/null 2>&1; then

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Restart stops other desktop sessions

If one user has two Hyprland sessions running the same shell config, this call to omarchy-restart-shell kills both shells through --any-display but launches a replacement only in the first compositor. The second record then loses its saved PID and is deleted without restarting that session. This can also kill the second session's lock screen without checking it.

Restart only the recorded session, and check its lock before stopping its shell.

@taxin-404

Copy link
Copy Markdown
Contributor Author

Correction to my previous comment: I said config-test.sh was green on this branch. It is green locally only, because my checkout sits next to an omarchy-pkgs tree with #1755 applied. CI checks out omarchy-pkgs master, which does not ship the two hook files yet, so the required test job fails on exactly that check:

omarchy PKGBUILD does not install default/libalpm/hooks/20-omarchy-shell-reload-pause.hook
omarchy PKGBUILD does not install default/libalpm/hooks/80-omarchy-shell-reload-resume.hook

The full VM run is 428/429 test files otherwise green (test/shell.d/config-test.sh is the only failure). Nothing else changed in the branch; the description now records this as the expected state. This clears when omarchy-pkgs#1755 merges — the two should land together.

@omarchybot

Copy link
Copy Markdown
Collaborator

Reclassified the current head, 79b505979cd06dbff54d6e0ade12a263c6f86d00, after reading the diff, discussion, review comments, linked issue #16126, and the base branch's contribution rules. GPT-6 in Codex (effort not exposed) classified it as a bug fix for the mid-update plugin-loading failure; the separate classifier, deepseek-v4p1-flash (effort not recorded), classified it as an enhancement. This was classification only; a correctness review and worker tests have not run.

The classification remains unsettled. The missing-action notifications still introduce behavior for calls outside package updates alongside the transaction guard. This waits on the maintainer to decide the scope of that combined change before verification proceeds. No labels were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants