Skip to content

Report a missing VAAPI driver when recording cannot initialize it - #18027

Open
DanielJBurbridge wants to merge 3 commits into
omacom:quattrofrom
DanielJBurbridge:cursor/screenrecord-vaapi-detect-f2ea
Open

DanielJBurbridge wants to merge 3 commits into
omacom:quattrofrom
DanielJBurbridge:cursor/screenrecord-vaapi-detect-f2ea

Conversation

@DanielJBurbridge

@DanielJBurbridge DanielJBurbridge commented Nov 7, 2026 •

Copy link
Copy Markdown

When recording startup fails because VAAPI cannot load its driver, report the driver failure rather than leaving an unexplained recorder exit. Capture a bounded startup stderr tail, drain later output, and use a deadline that remains bounded with streaming/stalled stderr and non-period clock separators. Keep persistent logs behind debug mode.

Related: #2706.

Validation on 8 November 2026:

  • bash test/shell.d/screenrecording-test.sh passed (isolated fixtures, graphical session disabled).
  • bash test/shell.d/i18n-test.sh passed (isolated fixtures, graphical session disabled).

Recorder/driver behaviour is mocked; no live GPU recording was performed. Translation-completeness check reports its structural-mode skip.

This originated in an unattended GrokBot batch, using spare weekly model allowance to contribute fixes to Omarchy issues. The batch needed more review before submission. This PR has since had a follow-up Codex audit; the validation and limits above describe what was actually checked.

gpu-screen-recorder logs vaInitialize failed and keeps going on the CPU.
That line was discarded, so a hybrid laptop with no Intel driver never
heard why encoding left the GPU.

Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the previous timeout issue is fixed and no new actionable issues were found.

Summary

This PR reports VAAPI startup failures without stopping a recording that can continue.

  • Screen recordings report VAAPI failures and suggest the matching GPU driver.

Reviews (3) · Last reviewed commit: "Normalize recording startup clock across..." · Reviewed by Greptile

Comment thread bin/omarchy-capture-screenrecording Resolved
Comment thread bin/omarchy-capture-screenrecording Resolved
Comment thread bin/omarchy-capture-screenrecording Resolved
@omarchybot

Copy link
Copy Markdown
Collaborator

Codex (GPT-6; reasoning effort not exposed by this session) read the diff, existing review comments and #2706. I classified the silent VAAPI startup failure as a bug, but the configured classification model, deepseek-v4p1-flash (effort not reported), returned no class. Classification remains unresolved, so this pass stops here for the maintainer to settle it.

No worker tests or second code review ran, and no code or labels changed. The separate review service answered its health check; the missing answer was from classification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants