Repository navigation
Show why a screen recording failed to start, in the recorder's own words - #19094
Closed
omarchybot wants to merge 4 commits into
Closed
omarchybot wants to merge 4 commits into
omarchybot wants to merge 4 commits into
Conversation
When no recorder comes up, the start now tries once more with the OMARCHY_SCREENRECORD_DEBUG log on, takes the first lines each recorder wrote there that read as an error, and shows them under a translated "Screen recording failed to start" title, exiting 1. A cancel (picker escape, a toggle during the start or while it fails, the portal picker dismissed) stays silent, exits 0 and is never retried. The failure is reported only after the start marker is gone and no cancel is pending, the same handoff a successful start uses, and the retry repeats no audio-unavailable notice. Co-authored-by: ThePrimeagen <the.primeagen@gmail.com> Co-authored-by: juanitoclavel <juanitoclavel@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Codex Medium <noreply@openai.com>
Contributor
[Medium impact] The PR appears safe to merge; both previous findings are fixed and no new actionable issues were found. SummaryThe PR retries failed recording starts with logging enabled, then shows the recorder's error and exits 1 if recording still cannot start.
Reviews (2) · Last reviewed commit: "Let each try give its own audio notice a..." · Reviewed by Greptile |
When nothing a recorder wrote reads as an error, the notification took its last line as written, which could be Mesa's EGL warning or gsr's fps info line. Drop those before either branch, so such a recorder is named as giving no error message instead. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The second try of a failed start silenced every "Recording without audio" notice, so a loopback that loaded the first time and failed the second, possibly a whole recorder timeout later, recorded without that source and never said so. Remember which sources were reported instead. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Codex Medium <noreply@openai.com>
wf_audio_device runs in a command substitution, so the sources it remembered reporting never reached the next try, and silencing the whole retry instead could hide a loopback that failed only the second time. The shell already shows identical notifications within two seconds once, so a second notice is visible only when a recorder timeout separates the tries. Leave wf_audio_unavailable as it was. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Codex Medium <noreply@openai.com>
Collaborator
Author
|
Closing: the maintainer would rather fix the reasons recordings fail to start than add retry-and-report machinery around the start. Those causes are being collected from the reported failures and will be fixed directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no recorder came up,
omarchy-capture-screenrecordingexited 0 and said nothing: the recorder's stderr went to/dev/nullunlessOMARCHY_SCREENRECORD_DEBUG=truewas already set, which nobody sets before the first failure. A recording that never starts looked exactly like a keybinding that does nothing.Now a start that fails tries once more by itself with the debug log on, and shows what the recorder actually said there under a translated "Screen recording failed to start" title, then exits 1. On a machine where
gpu-screen-recordercannot use the GPU, the notification reads:The text is the first lines each recorder wrote to the log that read as an error, with colour codes, carriage-return progress and warnings (Mesa's EGL chatter, gsr's info lines) dropped, at most two lines and 300 characters per recorder. Where
wf-recorderwas tried too, each line is prefixed with the recorder it came from; a recorder that printed nothing is named as giving no error message. The second try's output stays in$XDG_RUNTIME_DIR/omarchy-screenrecord.log, so a bug report has a log to attach without anyone having known to turn debugging on.gpu-screen-recorderexits 60 for that,PORTAL_CAPTURE_CANCELED_BY_USER_EXIT_CODE). The failure is reported only after the start marker is removed and no cancel is pending, the same handoff a successful start uses, and no recorder is launched once a cancel has arrived.wf-recorderstart that drops an unavailable audio source gives its "Recording without … audio" notice on each try. The shell folds an identical notice within two seconds into the card already showing, so a second one appears only when the tries are further apart, as when a recorder times out; holding the retry's notices back could hide a source that failed only the second time.Replaces #7189, which notified with a generic message asking the user to set
OMARCHY_SCREENRECORD_DEBUGand retry themselves. The guard that keeps a cancel silent before notifying, the title, and exiting 1 on a real failure come from #18803 by ThePrimeagen; the failure notification itself was first proposed in #7189 by Literato2. #18027 reports one cause of the same failure (a missing VAAPI driver) from a bounded stderr capture; this reports whatever the recorder says, that included.🤖 Generated by Claude Opus 5.5 in Claude Code. Reviewed by Codex Medium.