Repository navigation
Conversation
The startup wait already notices when gpu-screen-recorder dies before it writes the output file, but the failure branch did nothing: no message, and the script still exited 0. A recording that never starts looks exactly like a keybinding that does nothing. Notify on that path and return non-zero, which the caller already treats as failure by tearing down the webcam overlay. Point at the existing debug variable, since the stderr that explains the failure goes to /dev/null unless it is set.
|
The missing else is the right fix.
One leftover I'd leave for a follow-up, same as you noted: the caller is still Read against current |
|
Reviewed at 6b563c3 and reproduced on a worker built from the Omarchy ISO. Nothing found that needs changing. Reproduction. I made the real What else it fixes. Returning 1 means the Second opinion. Codex at medium effort reviewed the same diff and found no defects. It traced every path into the new branch and pointed out the webcam cleanup above. It may have read this review in progress, so its agreement is not guaranteed to be independent. It also raised two points that don't block this PR:
As you noted, This is labelled |
quattro now tries each installed recorder in turn and returns 1 only once every backend has failed to start, with the picker and cancel paths returning earlier. The notification moves to that final return, so it fires when no recorder started and stays silent when the user cancels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A recorder that never creates its file is stopped after the ready timeout, which can take two seconds, and the loop moves on without checking for a cancel. When that was the last backend, a cancel arriving meanwhile reached the failure notification. Co-Authored-By: Codex Medium <noreply@openai.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Re-reviewed after What changed on One fix on top. A recorder that never creates its file is stopped after the ready timeout, which can take up to two seconds, and the loop moves on without checking for a cancel. If that was the last backend, a cancel arriving in those two seconds reached the failure notification. A Reproduction, on a worker built from the Omarchy ISO. I made the real Second opinion. Codex at medium effort reviewed both rounds. The first found the cancel edge above. The second, on 123a4b2, found nothing further. Codex may have read this review in progress, so its agreement in the second round is not guaranteed to be independent. The script's own exit status after a failed start is unchanged, as you noted in the description. This is labelled |
A cancel that lands while the last recorder is being stopped after its ready timeout reached the failure notification, so cancelling could report a failed start and exit 1. The notification now also points at OMARCHY_SCREENRECORD_DEBUG, since the recorder's stderr goes to /dev/null without it. Both come from omacom#7189. Co-Authored-By: Literato2 <317679755+Literato2@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Closing in favour of #19094. The maintainer wants a failed start to be actionable on its own: #19094 retries the start once with the debug log on and puts the recorder's actual error in the failure notification, rather than asking the user to turn on debugging and try again. Your notification and cancel handling informed it, and you're credited there. Reviewed by Claude Opus 5.5 with Codex Medium as a second opinion; its independence is not guaranteed. |
start_screenrecordingalready notices whengpu-screen-recorderdies before writing the output file — the wait loop breaks on the dead pid and thekill -0guard fails — but the failure branch didn't exist. No notification, nothing on screen. A recording that never starts is indistinguishable from a keybinding that does nothing, and the stderr explaining why goes to/dev/nullunlessOMARCHY_SCREENRECORD_DEBUG=trueis already set, which nobody sets before the first failure.This adds the missing
else: notify, and return non-zero, which the caller at the bottom already treats as failure (start_screenrecording || cleanup_webcam).Verified by forcing a start failure — the notification fires with the message pointing at the debug variable.
Independent of #7184 and of the portal-ordering PR; this one is about surfacing any start failure, whatever the cause.
One thing I left alone: the script's own exit status still comes from that
|| cleanup_webcam, soomarchy capture screenrecordingcontinues to exit 0 on failure. Happy to change that too if you'd want it.