Skip to content

Filter keyring update warnings on non-English locales - #18620

Open
Roddygithub wants to merge 1 commit into
omacom:quattrofrom
Roddygithub:fix/keyring-locale-filter
Open

Roddygithub wants to merge 1 commit into
omacom:quattrofrom
Roddygithub:fix/keyring-locale-filter

Conversation

@Roddygithub

@Roddygithub Roddygithub commented Nov 12, 2026 •

Copy link
Copy Markdown

No description provided.

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change is limited to the signing-key refresh in the update.

Update the keyring test before merging; its command checks no longer match the refresh.

Findings

  1. P1 Keyring tests fail ▶

Summary

Forces the keyring refresh to use LC_ALL=C so the existing English warning filter works on non-English systems.

  • The keyring refresh keeps pacman messages in English across locales.

Reviews (1) · Last reviewed commit: "Filter keyring warnings on non-English l..." · Reviewed by Greptile

fi
echo -e "\e[32m\nUpdate signing keys\e[0m"
sudo pacman -Sy --needed --noconfirm "${keyrings[@]}" >/dev/null 2> >(grep -vE '^warning: [a-z0-9@._+-]+-keyring-[^ ]+ is up to date -- skipping$' >&2)
sudo env LC_ALL=C pacman -Sy --needed --noconfirm "${keyrings[@]}" >/dev/null 2> >(grep -vE '^warning: [a-z0-9@._+-]+-keyring-[^ ]+ is up to date -- skipping$' >&2)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Keyring tests fail

test/shell.d/update-keyring-test.sh still expects sudo pacman ..., so adding env LC_ALL=C makes its assertion at line 174 fail. Its sudo stub also checks $1 == "pacman", so it no longer emits the test warnings or simulates a failed refresh. Update the stub and command expectations to accept the wrapper so the suite passes and still checks warning filtering and error handling.

@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks @Roddygithub — this is the right fix, and you got there first: you reported and diagnosed it in #18477, and pinning LC_ALL=C on that one pacman call is exactly what keeps the English-only filter working on a French (or any non-English) system.

#18634 by @AnPod makes the identical change to bin/omarchy-update-keyring, and also updates test/shell.d/update-keyring-test.sh, which this one leaves as it was. Without that update the keyring test fails: its sudo stub dispatches on $1 == "pacman" (lines 65 and 87), so with env LC_ALL=C in front it never simulates the up-to-date notices or the refresh failure, and the assertion at line 174 still expects sudo pacman -Sy …. #18634 teaches the stub to step past env VAR=… and updates those assertions, and it links #18477.

So I've recommended #18634 to the maintainer, who decides between the two; this one stays open until then, and there is nothing here that #18634 is missing. This was checked by reading both diffs and tracing the test by hand; no tests were run, since only one of the two will merge. Reviewed by Claude Opus 5.5, with a second opinion from Codex Medium and muse-wonder (via pi, thinking high), each asked which of the two should win without being told my answer. Both picked #18634 for the same reason (independence not guaranteed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants