Repository navigation
Filter keyring update warnings on non-English locales - #18620
Roddygithub wants to merge 1 commit into
Conversation
[Low impact] The change is limited to the signing-key refresh in the update. Update the keyring test before merging; its command checks no longer match the refresh. Findings
SummaryForces the keyring refresh to use
Reviews (1) · Last reviewed commit: "Filter keyring warnings on non-English l..." · Reviewed by Greptile |
| fi | ||
| echo -e "\e[32m\nUpdate signing keys\e[0m" | ||
| sudo pacman -Sy --needed --noconfirm "${keyrings[@]}" >/dev/null 2> >(grep -vE '^warning: [a-z0-9@._+-]+-keyring-[^ ]+ is up to date -- skipping$' >&2) | ||
| sudo env LC_ALL=C pacman -Sy --needed --noconfirm "${keyrings[@]}" >/dev/null 2> >(grep -vE '^warning: [a-z0-9@._+-]+-keyring-[^ ]+ is up to date -- skipping$' >&2) |
There was a problem hiding this comment.
test/shell.d/update-keyring-test.sh still expects sudo pacman ..., so adding env LC_ALL=C makes its assertion at line 174 fail. Its sudo stub also checks $1 == "pacman", so it no longer emits the test warnings or simulates a failed refresh. Update the stub and command expectations to accept the wrapper so the suite passes and still checks warning filtering and error handling.
|
Thanks @Roddygithub — this is the right fix, and you got there first: you reported and diagnosed it in #18477, and pinning #18634 by @AnPod makes the identical change to So I've recommended #18634 to the maintainer, who decides between the two; this one stays open until then, and there is nothing here that #18634 is missing. This was checked by reading both diffs and tracing the test by hand; no tests were run, since only one of the two will merge. Reviewed by Claude Opus 5.5, with a second opinion from Codex Medium and muse-wonder (via pi, thinking high), each asked which of the two should win without being told my answer. Both picked #18634 for the same reason (independence not guaranteed). |
No description provided.