Repository navigation
Conversation
Contributor
[Medium impact] The PR appears safe to merge based on the code reviewed; graphical behavior still needs the acceptance checks noted by the author. SummaryAdds WezTerm as an optional terminal with menu selection, launch support, theme colors, and font controls.
No new actionable issues found. Tests were not run during this review; graphical checks remain unverified. Reviews (8) · Last reviewed commit: "Preserve dangling WezTerm links during s..." · Reviewed by Greptile |
ekrako
force-pushed
the
fix/wezterm-pr-12808
branch
2 times, most recently
from
November 15, 2026 06:42
c178087 to
737390c
Compare
|
thanks @ekrako. I think I can close mine at this point. I hope this get merged soon :) |
ekrako
force-pushed
the
fix/wezterm-pr-12808
branch
3 times, most recently
from
November 17, 2026 07:38
3c77bae to
c2cb9da
Compare
Ships the default config, the themed color template, and a desktop entry carrying the X-TerminalArg* keys the packaged one lacks, so xdg-terminal-exec can pass WezTerm a command, an app id, and a directory. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
- Avoid shadowing user configs and desktop entries during installation - Return an error when terminal installation fails
ekrako
force-pushed
the
fix/wezterm-pr-12808
branch
from
November 18, 2026 07:30
c2cb9da to
0851bcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
WezTerm is missing from Omarchy's terminal picker. Add it as an optional terminal with installation/default selection, generated theme colors, font updates, and the correct terminal tag for clipboard routing.
This is a repaired follow-up to #12808, rebased onto current
quattroand preserving @iltumio's commit attribution. We could not push to the original head branch, so the repair is published here. It also:quattro's native Wayland screensaver; the original PR's terminal-based screensaver implementation is obsolete and has been omitted.The original fixes for migration naming, the
org.wezfurlong.weztermclass, and escaping font names are retained. The Lua regression test now propagates assertion failures correctly.Related: #4836 and the configurable RTL/BiDi terminal request in #18937. This does not change WezTerm's rendering engine or claim complete BiDi/TUI compatibility.
Verification
./test/all): CLI passed; all 424 shell test files finished, with skips in 41 files. Hermes removal, fingerprint removal, and update-hangup tests failed; each was also run once on unchangedquattroand failed there. The full suite is not claimed green.WEZTERM_CONFIG_FILE) and font-control/text-size suites pass. Native WezTerm key-table inspection confirms the tmux chords are no longer consumed; its Lua parser and Fontconfig lookup confirm the supplied config uses the selected monospace font.show-keyschecks verify invalid empty/eight-digit colors retain the other settings. The CLI suite passes with a custom italic font that remains unchanged during primary-family updates.quattroat8ef0207c2. The conflict resolution preserves upstream’s four-argument icon-set renderer interface alongside WezTerm’s locked single-file initialization; both paths pass the expanded template tests. A translation-only update landed during validation; its rebase preserves all 19 patches and leaves PR feature files unchanged. The i18n suite passed again on the final head.xdg-terminal-execlaunch ran the command in a directory containing spaces and sent the requested Wayland app ID.The disposable-VM graphical acceptance suite, Hyprland terminal-tag/clipboard interaction, and menu appearance remain unverified. An isolated Hyprland compositor could not initialize its backend. No installed desktop configuration was changed.
Screenshots
Tokyo Night in the isolated WezTerm session:
The same running window after reloading generated Catppuccin Latte colors; its previously printed title is unchanged:
Council review
Rounds: 3 attempted. All four requested models completed a review; their latest scores are 9/10 on the reviewed
dd515dehead.Round 1 found tmux key conflicts, shared-process cwd ambiguity, a gap for later package-only installations, missing text-size integration, initial-font behavior, and small migration/Foot compatibility issues. These were fixed before round 2. Grok's first pass was canceled before completion to apply the requested fixes; no score was inferred.
A later Greptile finding exposed a concurrent theme-switch race in missing-file rendering. It was reproduced and fixed by holding the existing theme-switch lock across palette read and output write. The regression fails before the fix and passes afterward; template and staging suites pass. Astra and Grok's round-3 reviews were satisfied at 9/10, and Greptile confirmed the fix at 5/5.
The quota-delayed Opus and Fable round-2 requests resumed and reviewed the complete
dd515dehead, including the lock fix. Both returned satisfied at 9/10 with no blockers. Those are single completed reviews, not additional independent round-3 passes. No substitute models were used.Fable's three final low-severity follow-ups were then fixed directly: dangling links are preserved during setup, invalid palettes cannot discard the other config settings, and font-family edits leave custom font rules alone. Focused regressions, native WezTerm checks and the CLI suite pass. The final hardening and later rebases, including the icon-set renderer conflict resolution, have not received another council score; the scores above apply to the reviewed head, not a claimed new audit.
GitHub Actions still require maintainer approval before the workflows can run; this account cannot approve them. The full suite and graphical coverage limits are recorded above.
Repair prepared with GPT-6.1 Sol in the Codex harness through T3 Code.