Skip to content

Add WezTerm to the terminal picker - #18939

Open
ekrako wants to merge 19 commits into
omacom:quattrofrom
ekrako:fix/wezterm-pr-12808
Open

ekrako wants to merge 19 commits into
omacom:quattrofrom
ekrako:fix/wezterm-pr-12808

Conversation

@ekrako

@ekrako ekrako commented Nov 14, 2026 •

Copy link
Copy Markdown

What changes

WezTerm is missing from Omarchy's terminal picker. Add it as an optional terminal with installation/default selection, generated theme colors, font updates, and the correct terminal tag for clipboard routing.

This is a repaired follow-up to #12808, rebased onto current quattro and preserving @iltumio's commit attribution. We could not push to the original head branch, so the repair is published here. It also:

  • Supplies missing configuration in an existing directory while preserving custom settings, desktop entries, and alternate WezTerm configuration locations.
  • Preserves the current default terminal when package installation fails and seeds defaults for users who install the optional package later.
  • Uses one WezTerm process per terminal launch so cwd detection stays tied to the focused window, passes Omarchy's tmux split/resize chords through, respects the selected monospace family on first launch, and integrates with desktop text sizing.
  • Initializes missing WezTerm colors from the selected theme without refreshing other apps, and preserves config symlinks during font changes.
  • Integrates the new menu rows with the English catalog and verifies that installed themes cannot supply executable WezTerm Lua in place of generated colors.
  • Keeps quattro's native Wayland screensaver; the original PR's terminal-based screensaver implementation is obsolete and has been omitted.

The original fixes for migration naming, the org.wezfurlong.wezterm class, and escaping font names are retained. The Lua regression test now propagates assertion failures correctly.

Related: #4836 and the configurable RTL/BiDi terminal request in #18937. This does not change WezTerm's rendering engine or claim complete BiDi/TUI compatibility.

Verification

  • Latest aggregate validation after resolving the icon-set renderer conflict (./test/all): CLI passed; all 424 shell test files finished, with skips in 41 files. Hermes removal, fingerprint removal, and update-hangup tests failed; each was also run once on unchanged quattro and failed there. The full suite is not claimed green.
  • After the council fixes, the affected CLI, default-apps (with an exported WEZTERM_CONFIG_FILE) and font-control/text-size suites pass. Native WezTerm key-table inspection confirms the tmux chords are no longer consumed; its Lua parser and Fontconfig lookup confirm the supplied config uses the selected monospace font.
  • Two real WezTerm GUI processes in an isolated display retain different cwd values, including paths with spaces. The migration is checked with package absence simulated and provides the later-install defaults without replacing existing files.
  • Temporary-home migration checks cover missing configuration, custom files/modules/desktop entries, repeated runs, and alternate configuration paths.
  • Final Fable follow-ups: the installer regression preserves dangling config/desktop links, a strict-mode migration reproducer fails before the fix and succeeds afterward, and real WezTerm show-keys checks verify invalid empty/eight-digit colors retain the other settings. The CLI suite passes with a custom italic font that remains unchanged during primary-family updates.
  • Rebased onto quattro at 8ef0207c2. The conflict resolution preserves upstream’s four-argument icon-set renderer interface alongside WezTerm’s locked single-file initialization; both paths pass the expanded template tests. A translation-only update landed during validation; its rebase preserves all 19 patches and leaves PR feature files unchanged. The i18n suite passed again on the final head.
  • A real xdg-terminal-exec launch ran the command in a directory containing spaces and sent the requested Wayland app ID.
  • Actual WezTerm runtime in an isolated headless Weston compositor: inspected dark/light theme rendering and verified that replacing the generated theme and touching the configuration updates the same running window.
  • Bash/Lua syntax, desktop entry validation, diff whitespace checks, and applying the aggregate patch to the target tree passed.

The disposable-VM graphical acceptance suite, Hyprland terminal-tag/clipboard interaction, and menu appearance remain unverified. An isolated Hyprland compositor could not initialize its backend. No installed desktop configuration was changed.

Screenshots

Tokyo Night in the isolated WezTerm session:

WezTerm using generated Tokyo Night colors

The same running window after reloading generated Catppuccin Latte colors; its previously printed title is unchanged:

Same WezTerm session after live theme reload

Council review

Rounds: 3 attempted. All four requested models completed a review; their latest scores are 9/10 on the reviewed dd515de head.

Delegate Round 1 Round 2 Round 3
GPT-6 Astra (high) 9/10 9/10 9/10
Claude Opus 5.5 (high) 7/10 9/10 (resumed on dd515de) no separate pass
Grok 4.7 (high) no score 9/10 9/10
Claude Fable 5.2 (high) 8/10 9/10 (resumed on dd515de) no separate pass

Round 1 found tmux key conflicts, shared-process cwd ambiguity, a gap for later package-only installations, missing text-size integration, initial-font behavior, and small migration/Foot compatibility issues. These were fixed before round 2. Grok's first pass was canceled before completion to apply the requested fixes; no score was inferred.

A later Greptile finding exposed a concurrent theme-switch race in missing-file rendering. It was reproduced and fixed by holding the existing theme-switch lock across palette read and output write. The regression fails before the fix and passes afterward; template and staging suites pass. Astra and Grok's round-3 reviews were satisfied at 9/10, and Greptile confirmed the fix at 5/5.

The quota-delayed Opus and Fable round-2 requests resumed and reviewed the complete dd515de head, including the lock fix. Both returned satisfied at 9/10 with no blockers. Those are single completed reviews, not additional independent round-3 passes. No substitute models were used.

Fable's three final low-severity follow-ups were then fixed directly: dangling links are preserved during setup, invalid palettes cannot discard the other config settings, and font-family edits leave custom font rules alone. Focused regressions, native WezTerm checks and the CLI suite pass. The final hardening and later rebases, including the icon-set renderer conflict resolution, have not received another council score; the scores above apply to the reviewed head, not a claimed new audit.

GitHub Actions still require maintainer approval before the workflows can run; this account cannot approve them. The full suite and graphical coverage limits are recorded above.

Repair prepared with GPT-6.1 Sol in the Codex harness through T3 Code.

@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge based on the code reviewed; graphical behavior still needs the acceptance checks noted by the author.

Summary

Adds WezTerm as an optional terminal with menu selection, launch support, theme colors, and font controls.

  • WezTerm can be installed and picked as the default terminal.
  • WezTerm launches with Omarchy’s terminal shortcuts and window rules.
  • WezTerm colors follow Omarchy’s selected theme.
  • Omarchy’s font controls now update WezTerm.

No new actionable issues found. Tests were not run during this review; graphical checks remain unverified.

Reviews (8) · Last reviewed commit: "Preserve dangling WezTerm links during s..." · Reviewed by Greptile

Comment thread migrations/1794685404.sh Resolved
Comment thread bin/omarchy-font-set Resolved
Comment thread test/shell.d/default-apps-test.sh Resolved
Comment thread test/shell.d/wezterm-font-test.sh Resolved
Comment thread bin/omarchy-theme-set-templates Resolved
@ekrako
ekrako force-pushed the fix/wezterm-pr-12808 branch 2 times, most recently from c178087 to 737390c Compare November 15, 2026 06:42
@iltumio

iltumio commented Nov 15, 2026

Copy link
Copy Markdown

thanks @ekrako. I think I can close mine at this point. I hope this get merged soon :)

@ekrako
ekrako force-pushed the fix/wezterm-pr-12808 branch 3 times, most recently from 3c77bae to c2cb9da Compare November 17, 2026 07:38
@omarchybot omarchybot added the enhancement New feature or request label Nov 17, 2026
iltumio and others added 19 commits November 18, 2026 04:47
Ships the default config, the themed color template, and a desktop entry
carrying the X-TerminalArg* keys the packaged one lacks, so xdg-terminal-exec
can pass WezTerm a command, an app id, and a directory.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
- Avoid shadowing user configs and desktop entries during installation
- Return an error when terminal installation fails
@ekrako
ekrako force-pushed the fix/wezterm-pr-12808 branch from c2cb9da to 0851bcd Compare November 18, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants