Repository navigation
Conversation
|
Source review found one clipboard integration issue in the newly supported default WezTerm launch. Ordinary WezTerm windows miss the terminal clipboard shortcutsThe normal Super+Return launcher does not override the app ID, so WezTerm uses
This is a source-derived routing comparison, not an observed GUI test. The PR already binds the two Insert chords to WezTerm copy/paste, but ordinary default-class windows do not reach them. Explicitly classed Impact: Super+C can interrupt a foreground command instead of copying, and Super+V does not invoke the configured paste action. Suggested change: Add Review informationTest scope: Source inspection at Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra Medium initial inspection, independent Opus 5.5 High and GPT 6 Sol Xhigh technical reviews, then Astra Medium synthesis and source-based verification of the retained finding. |
|
Two things to fix before this can land: Migration filename collision (blocking). git mv migrations/1786961462.sh "migrations/$(date +%s).sh"Terminal tag for the default class. As @llstrk noted, a plain Also related: #13841 adds WezTerm screensaver support separately, so it overlaps your |
[Medium impact] The changes affect Omarchy users who install or use WezTerm. Fix the failing menu and theme checks, and satisfy the migration-test rule before merging. Findings
SummaryAdds WezTerm installation and default-terminal choices, desktop launch support, theme colors, font updates, and a migration for existing installations.
Reviews (4) · Last reviewed commit: "fix: escape WezTerm font names when upda..." · Reviewed by Greptile |
|
Addressed the three Greptile findings:
Validation: focused screensaver, migration, and font regression tests; existing Kitty font-control tests (native Kitty parser skipped because Kitty is not installed); CLI suite; Bash syntax and diff checks. Also verified two fullscreen WezTerm screensaver windows and effects on the running two-monitor session. |
847c37e to
fe4e167
Compare
|
Opened a repaired follow-up at #18939: #18939. It carries this PR's WezTerm support and existing fixes forward onto current The new PR includes inspected runtime screenshots and validation details. Focused checks pass; it also documents the unrelated broad-suite failures and the graphical acceptance checks that remain unverified. We could not update this branch because the authenticated account lacks push permission, so this PR itself has not been changed or closed. |
Ships the default config, the themed color template, and a desktop entry carrying the X-TerminalArg* keys the packaged one lacks, so xdg-terminal-exec can pass WezTerm a command, an app id, and a directory. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fe4e167 to
a08e1e7
Compare
| "setup.default.terminal.foot": {"icon":"","label":"Foot","checked":"[[ \"$(omarchy-default-terminal)\" == \"foot\" ]]","action":"omarchy-default-terminal foot"}, | ||
| "setup.default.terminal.ghostty": {"icon":"","label":"Ghostty","checked":"[[ \"$(omarchy-default-terminal)\" == \"ghostty\" ]]","action":"omarchy-default-terminal ghostty"}, | ||
| "setup.default.terminal.kitty": {"icon":"","label":"Kitty","checked":"[[ \"$(omarchy-default-terminal)\" == \"kitty\" ]]","action":"omarchy-default-terminal kitty"}, | ||
| "setup.default.terminal.wezterm": {"icon":"","label":"WezTerm","checked":"[[ \"$(omarchy-default-terminal)\" == \"wezterm\" ]]","action":"omarchy-default-terminal wezterm"}, |
There was a problem hiding this comment.
English menu entries are missing
The two new WezTerm rows have no matching entries in default/i18n/en/menu.json. i18n-test.sh requires every menu row to appear there, so these additions fail the English catalog check. Add entries for both setup.default.terminal.wezterm and install.terminal.wezterm; translations can follow separately.
| @@ -0,0 +1,31 @@ | |||
| return { | |||
There was a problem hiding this comment.
The new wezterm.lua.tpl is absent from both lists in theme-staging-test.sh, so its check of every template fails. The theming guide also requires new terminal templates to be added to INSTALLED_THEME_DENIED. Classify wezterm.lua in the test and update the required list. The existing *.lua guard already blocks downloaded Lua files, so this is not a new code-execution hole.
File Used: docs/theming.md (source)
| # Escape the Lua string first, then the sed replacement. Match escaped quotes | ||
| # too, so another font change can replace a previously escaped name in full. | ||
| wezterm_font_name=$(printf '%s' "$font_name" | sed 's/[\\"]/\\&/g; s/[\\&/]/\\&/g') | ||
| sed -i -E "s/wezterm\\.font\\(\"([^\"\\\\]|\\\\.)*\"/wezterm.font(\"$wezterm_font_name\"/g" ~/.config/wezterm/wezterm.lua |
There was a problem hiding this comment.
Font changes break config links
If wezterm.lua is a symlink into a dotfiles directory, changing the font replaces that link with a regular file because this uses plain sed -i. The target keeps the old font, and later edits to it no longer reach the active config. Use --follow-symlinks, as the Kitty branch does.
| sed -i -E "s/wezterm\\.font\\(\"([^\"\\\\]|\\\\.)*\"/wezterm.font(\"$wezterm_font_name\"/g" ~/.config/wezterm/wezterm.lua | |
| sed --follow-symlinks -i -E "s/wezterm\\.font\\(\"([^\"\\\\]|\\\\.)*\"/wezterm.font(\"$wezterm_font_name\"/g" ~/.config/wezterm/wezterm.lua |
| run_migration() { | ||
| env HOME="$test_home" OMARCHY_PATH="$ROOT" PATH="$mock_bin:$PATH" \ | ||
| bash -euo pipefail "$ROOT/migrations/1791536351.sh" >/dev/null | ||
| } |
There was a problem hiding this comment.
Migration suite violates test rules
This adds a dedicated migration test, contrary to the explicit AGENTS.md rule: “No test for a migration.” Remove this suite before merging and check the migration against a temporary home while developing it. If its logic needs lasting test coverage, move that logic into a bin/ command and test that command.
File Used: AGENTS.md (source)
Add WezTerm as a supported terminal in Omarchy Quattro. Users can install it and select it as the default through the CLI or menu, with Omarchy theme colors, font changes, and screensaver support.
X-TerminalArg*keys forxdg-terminal-exec.omarchy-font-set.Supersedes #4836 for Omarchy Quattro.
Validation:
./test/clibash test/shell.d/default-apps-test.shbash test/shell.d/menu-test.shgit diff --check upstream/quattro...HEADAll checks passed after rebasing onto
quattro. Graphical screensaver behavior has not been reverified after the rebase.