Repository navigation
Fix emoji paste in Firefox - #6892
VBNorebert wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates emoji insertion to use a plain-text paste shortcut compatible with native Wayland Firefox.
Changes:
- Replaces
Shift+InsertwithCtrl+Shift+V. - Updates the regression test for the new key sequence.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-menu-emoji-insert |
Uses the cross-application plain-text paste shortcut. |
test/shell.d/emojis-test.sh |
Verifies the updated wtype invocation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ctrl+Shift+V opens Paste Special in LibreOffice rather than pasting, and the helper drops the clipboard 0.2s later, so the emoji never lands. Pick the shortcut the way the universal paste binding does: Ctrl+Shift+V for windows tagged terminal, Ctrl+V everywhere else, which Firefox accepts too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for this. The Firefox bug is real. On an Omarchy VM, the emoji picker's synthetic Shift+Insert left a native-Wayland Firefox text field empty, and your change made the emoji land. Sending Ctrl+Shift+V to every window broke LibreOffice Writer, though. There, Ctrl+Shift+V opens the Paste Special dialog, and the helper withdraws the clipboard 0.2s later, so the emoji is lost. GIMP binds the same chord to Paste as New Image. So I pushed 24d1f2b to your branch. It picks the chord the way What was checked, on a disposable Omarchy VM at 24d1f2b:
Codex Medium reviewed it twice as a second opinion. It found the LibreOffice regression and GIMP's binding, and nothing left to act on at 24d1f2b; its agreement is not guaranteed to be independent. It raised terminals that don't carry the tag and apps that bind Ctrl+V to something else, such as Emacs. Those cases behave the same way under Two other open pull requests change the same helper. #8573 also re-focuses the window the picker was opened from, and #12377 routes the clipboard manager's paste through a shared helper, but it still sends Shift+Insert to terminals, which quattro no longer does. Codex was asked which of the three to bring forward without being told my answer, and it chose this one: it fixes the Firefox bug with the smallest change, consistent with quattro. The clipboard manager's paste ( Nothing is left for you to do. This is waiting on the maintainer. |
Resolves the conflict in emojis-test.sh with quattro's readiness-signal stubs (omacom#16338): both helper runs now publish to $TMPDIR/emoji, and the terminal run clears it first so the sleep stub still waits for its own copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch had stopped merging cleanly. #16338 rewrote the stubs in What was checked, on a disposable Omarchy VM at 8bfc9ac:
Codex Medium and muse-wonder (pi, high effort) reviewed the merge and found nothing wrong; their agreement is not guaranteed to be independent. They were also asked to compare this pull request again with #8573 and #12377, which have both changed since the last comparison. Both picked this one. It is the oldest, and #8573's paste change is equivalent to it. #12377 does not change the emoji helper. Both reviewers pointed to #8573's other change, re-focusing the window the picker was opened from after a mouse pick, as a separate bug fix worth keeping. That is on #8573. One thing for you, @VBNorebert, if you have a moment: the description still says Ctrl+Shift+V is sent everywhere. The code now sends Ctrl+Shift+V to terminals and Ctrl+V to everything else, the same as |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryChanges emoji insertion to use
Reviews (1) · Last reviewed commit: "Merge quattro into fix/firefox-emoji-pas..." · Reviewed by Greptile |
What changed
Use
Ctrl+Shift+Vinstead ofShift+Insertwhen inserting an emoji.Why
The emoji picker copies the selected emoji to a temporary clipboard and simulates a paste.
Shift+Insertdoes not paste into Firefox inputs under native Wayland, whileCtrl+Shift+Vworks as a plain-text paste across both GUI applications and terminals.Manually verified with:
Tests
bash test/shell.d/emojis-test.shFixes #12376