Skip to content

Fix emoji paste in Firefox - #6892

Open
VBNorebert wants to merge 3 commits into
omacom:quattrofrom
VBNorebert:fix/firefox-emoji-paste
Open

VBNorebert wants to merge 3 commits into
omacom:quattrofrom
VBNorebert:fix/firefox-emoji-paste

Conversation

@VBNorebert

@VBNorebert VBNorebert commented Aug 14, 2026 •

Copy link
Copy Markdown

What changed

Use Ctrl+Shift+V instead of Shift+Insert when inserting an emoji.

Why

The emoji picker copies the selected emoji to a temporary clipboard and simulates a paste. Shift+Insert does not paste into Firefox inputs under native Wayland, while Ctrl+Shift+V works as a plain-text paste across both GUI applications and terminals.

Manually verified with:

  • Firefox
  • Chrome
  • Ghostty
  • Obsidian

Tests

  • Updated the emoji insertion regression test
  • bash test/shell.d/emojis-test.sh

Fixes #12376

Copilot AI balanced review requested due to automatic review settings August 14, 2026 19:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates emoji insertion to use a plain-text paste shortcut compatible with native Wayland Firefox.

Changes:

  • Replaces Shift+Insert with Ctrl+Shift+V.
  • Updates the regression test for the new key sequence.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
bin/omarchy-menu-emoji-insert Uses the cross-application plain-text paste shortcut.
test/shell.d/emojis-test.sh Verifies the updated wtype invocation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Ctrl+Shift+V opens Paste Special in LibreOffice rather than pasting, and the helper drops the clipboard 0.2s later, so the emoji never lands. Pick the shortcut the way the universal paste binding does: Ctrl+Shift+V for windows tagged terminal, Ctrl+V everywhere else, which Firefox accepts too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omarchybot omarchybot added verified Omarchy Triage has verified that this issue is ready for final review ready Good to merge labels Sep 28, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for this. The Firefox bug is real. On an Omarchy VM, the emoji picker's synthetic Shift+Insert left a native-Wayland Firefox text field empty, and your change made the emoji land.

Sending Ctrl+Shift+V to every window broke LibreOffice Writer, though. There, Ctrl+Shift+V opens the Paste Special dialog, and the helper withdraws the clipboard 0.2s later, so the emoji is lost. GIMP binds the same chord to Paste as New Image. So I pushed 24d1f2b to your branch. It picks the chord the way SUPER + V does on quattro (default/hypr/bindings/clipboard.lua): Ctrl+Shift+V for windows with the terminal tag, Ctrl+V everywhere else. The test now covers both branches and checks the hyprctl query.

What was checked, on a disposable Omarchy VM at 24d1f2b:

  • Firefox, Chromium, foot and LibreOffice Writer all insert the emoji. With quattro's helper, only Firefox failed.
  • emojis-test.sh fails with the helper reverted to quattro's version or to your original commit, and passes at the head.
  • ./test/cli, emojis-test.sh and clipboard-test.sh are green.

Codex Medium reviewed it twice as a second opinion. It found the LibreOffice regression and GIMP's binding, and nothing left to act on at 24d1f2b; its agreement is not guaranteed to be independent. It raised terminals that don't carry the tag and apps that bind Ctrl+V to something else, such as Emacs. Those cases behave the same way under SUPER + V today, so I left them alone.

Two other open pull requests change the same helper. #8573 also re-focuses the window the picker was opened from, and #12377 routes the clipboard manager's paste through a shared helper, but it still sends Shift+Insert to terminals, which quattro no longer does. Codex was asked which of the three to bring forward without being told my answer, and it chose this one: it fixes the Firefox bug with the smallest change, consistent with quattro. The clipboard manager's paste (omarchy-clipboard-paste-text, omarchy-clipboard-paste-file) still uses Shift+Insert, so it likely has the same Firefox problem. That is worth its own change. #12376 reports this bug in Zen, which is Firefox-based. Its Chromium half did not reproduce here, so this doesn't claim to close it.

Nothing is left for you to do. This is waiting on the maintainer.

Resolves the conflict in emojis-test.sh with quattro's readiness-signal stubs (omacom#16338): both helper runs now publish to $TMPDIR/emoji, and the terminal run clears it first so the sleep stub still waits for its own copy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omarchybot omarchybot added the verified Omarchy Triage has verified that this issue is ready for final review label Oct 31, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

This branch had stopped merging cleanly. #16338 rewrote the stubs in test/shell.d/emojis-test.sh on quattro. I pushed 8bfc9ac, which merges quattro into your branch and moves your two cases onto the new stubs. The helper is unchanged. Each helper run now waits for its own clipboard copy, so it keeps quattro's readiness signal instead of the fixed sleeps.

What was checked, on a disposable Omarchy VM at 8bfc9ac:

  • In a Firefox textarea, quattro's helper still inserts nothing, and the helper on this branch inserts the emoji. A foot window tagged terminal gets the emoji too.
  • emojis-test.sh fails with the helper reverted to quattro's version, and passes at the head.
  • ./test/cli, emojis-test.sh and clipboard-test.sh are green.

Codex Medium and muse-wonder (pi, high effort) reviewed the merge and found nothing wrong; their agreement is not guaranteed to be independent. They were also asked to compare this pull request again with #8573 and #12377, which have both changed since the last comparison. Both picked this one. It is the oldest, and #8573's paste change is equivalent to it. #12377 does not change the emoji helper. Both reviewers pointed to #8573's other change, re-focusing the window the picker was opened from after a mouse pick, as a separate bug fix worth keeping. That is on #8573.

One thing for you, @VBNorebert, if you have a moment: the description still says Ctrl+Shift+V is sent everywhere. The code now sends Ctrl+Shift+V to terminals and Ctrl+V to everything else, the same as SUPER + V on quattro (default/hypr/bindings/clipboard.lua). Updating the description would save a reader from comparing the two. Otherwise this is waiting on the maintainer. They also decide whether this logic should become a shared paste helper that omarchy-clipboard-paste-text and omarchy-clipboard-paste-file could use, since both still send Shift+Insert.

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Changes emoji insertion to use Ctrl+Shift+V in tagged terminal windows and Ctrl+V elsewhere.

  • Emoji insertion picks a paste shortcut for the active window.

Reviews (1) · Last reviewed commit: "Merge quattro into fix/firefox-emoji-pas..." · Reviewed by Greptile

@omarchybot omarchybot removed the verified Omarchy Triage has verified that this issue is ready for final review label Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emoji picker (SUPER+CTRL+E) fails to insert into browsers; works in terminals

3 participants