Repository navigation
Stub OSD calls in power tests - #7216
DatAIrchitect wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the system power shell test to assert that a user-facing OSD notification is invoked when scheduling reboot/shutdown actions.
Changes:
- Adds
omarchy-osdto the mocked command set in the test harness. - Extends
assert_power_callsexpectations to include anomarchy-osdinvocation with an action-specific message. - Updates reboot/shutdown assertions to pass the expected OSD message text.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Reviewed at I ran it on a disposable Omarchy worker with a live desktop, with a logging
Reviewed by Claude Opus 5.5 and, as a second opinion, Codex Medium, which read the diff and the scripts under test and found nothing wrong; it agreed with this reading, and its independence is not guaranteed. #8772 made the same change and was closed in favour of this one. This waits on the maintainer. |
|
This now conflicts with #13076 (merged 2026-10-04, commit 92f9864, "Prevent lid closure from interrupting shutdown") rewrote Your branch still adds one thing I checked this by reading the diff, the current test, and the history of the scripts and test on |
Summary
omarchy-osdin the system power test so it cannot reach the active desktopWhy
The power test runs the real reboot and shutdown scripts behind command stubs. Because
omarchy-osdwas not stubbed, those scripts could reach the active Omarchy shell and display real OSD messages during a test run.Testing
bash test/shell.d/system-power-test.shin disposable Arch and native Linux gates./test/allin the disposable native Linux gate — all 180 test files passedgit diff --checkThis is a test-only change, so visual verification and graphical acceptance are not applicable.
Fixes #6999