Repository navigation
Hint at the ELAN 04f3:0c4b generic-driver matching bug in fingerprint setup - #7667
jcperdomoybarra wants to merge 1 commit into
Conversation
… setup fprintd-verify fails with a 0 score on 04f3:0c4b under the generic libfprint elan.c driver, with no indication that the driver is the problem rather than technique — confirmed on a ThinkPad E15 Gen3 AMD across 25+ verify attempts. Detect the known-risk device and, on a verify failure, point at the workaround (Lenovo's proprietary ELAN MOH driver via libfprint-tod) instead of just suggesting to try enrolling again. Detection lives in its own omarchy-hw-fingerprint-generic-driver-risk helper, mirroring omarchy-hw-fingerprint, with unit tests against the same OMARCHY_USB_DEVICES_PATH fixture pattern.
There was a problem hiding this comment.
Pull request overview
Adds targeted detection and guidance for ELAN 04f3:0c4b fingerprint readers affected by generic-driver verification failures.
Changes:
- Adds a hidden hardware-risk detector.
- Shows workaround guidance after verification failure.
- Adds detector tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-hw-fingerprint-generic-driver-risk |
Detects the affected USB ID. |
bin/omarchy-setup-security-fingerprint |
Adds targeted failure guidance. |
test/shell.d/hw-fingerprint-generic-driver-risk-test.sh |
Tests risk detection outcomes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Additional hardware data point for this PID: IdeaPad 3 14ALC6 ( On that chassis stock with fprintd logging a protocol error during identify-for-enroll. The hint added here is only on the verify-failure branch, so this model still gets Once Please also emit the |
What
Hardware: ELAN
04f3:0c4bfingerprint reader (confirmed on a ThinkPad E15 Gen3 AMD, likely present on other E14/E15 Gen3/Gen4 units — see #7483).Under the generic
libfprintelan.cdriver, this reader enrolls fine (fprintd-enrollcompletes normally) butfprintd-verifynever produces a working match — the score is consistently0regardless of technique, across 25+ verify attempts in my own testing.omarchy-setup-security-fingerprintcurrently reports this as a generic "Verification failed. You may want to try enrolling again." with no way to tell a driver limitation from a bad enrollment.Lenovo ships a proprietary "ELAN MOH" driver for this exact PID, usable on Linux via
libfprint-tod+ thelibfprint-2-tod1-elanAUR package. Switching to it fixed the reader completely (10/10 cleanverify-match,sudo/polkit/lock screen all working) — full writeup, evidence, and a reproducible procedure at https://github.com/jcperdomoybarra/thinkpad-elan-04f3-0c4b-fingerprint-fix. I filed #7483 with this same summary a couple of days ago; this PR is the actual code half of that.Why this shape
This does not bundle or install the proprietary driver — it's a closed-source binary from Lenovo, not something to pull into Omarchy directly. It only adds:
bin/omarchy-hw-fingerprint-generic-driver-risk— a small helper (mirrorsomarchy-hw-fingerprint's shape andOMARCHY_USB_DEVICES_PATHoverride for testability) that detects a known-risk reader by USB id and prints it.omarchy-setup-security-fingerprint's existing verify-failure branch, pointing at the workaround instead of just "try again" — only shown for the exact confirmed-affected id, not a general driver-quality guess.Kept the known-id list to just
04f3:0c4b(the one I've actually verified end to end) rather than guessing at siblings — easy to extend later if others confirm the same failure mode on a different PID.Testing
test/shell.d/hw-fingerprint-generic-driver-risk-test.sh(new), same fixture pattern ashw-fingerprint-test.sh.test/shellsuite locally — all passing, including the pre-existing fingerprint tests.🤖 Generated with Claude Code