Skip to content

Hint at the ELAN 04f3:0c4b generic-driver matching bug in fingerprint setup - #7667

Open
jcperdomoybarra wants to merge 1 commit into
omacom:quattrofrom
jcperdomoybarra:elan-04f3-0c4b-fingerprint-hint
Open

jcperdomoybarra wants to merge 1 commit into
omacom:quattrofrom
jcperdomoybarra:elan-04f3-0c4b-fingerprint-hint

Conversation

@jcperdomoybarra

Copy link
Copy Markdown

What

Hardware: ELAN 04f3:0c4b fingerprint reader (confirmed on a ThinkPad E15 Gen3 AMD, likely present on other E14/E15 Gen3/Gen4 units — see #7483).

Under the generic libfprint elan.c driver, this reader enrolls fine (fprintd-enroll completes normally) but fprintd-verify never produces a working match — the score is consistently 0 regardless of technique, across 25+ verify attempts in my own testing. omarchy-setup-security-fingerprint currently reports this as a generic "Verification failed. You may want to try enrolling again." with no way to tell a driver limitation from a bad enrollment.

Lenovo ships a proprietary "ELAN MOH" driver for this exact PID, usable on Linux via libfprint-tod + the libfprint-2-tod1-elan AUR package. Switching to it fixed the reader completely (10/10 clean verify-match, sudo/polkit/lock screen all working) — full writeup, evidence, and a reproducible procedure at https://github.com/jcperdomoybarra/thinkpad-elan-04f3-0c4b-fingerprint-fix. I filed #7483 with this same summary a couple of days ago; this PR is the actual code half of that.

Why this shape

This does not bundle or install the proprietary driver — it's a closed-source binary from Lenovo, not something to pull into Omarchy directly. It only adds:

  1. bin/omarchy-hw-fingerprint-generic-driver-risk — a small helper (mirrors omarchy-hw-fingerprint's shape and OMARCHY_USB_DEVICES_PATH override for testability) that detects a known-risk reader by USB id and prints it.
  2. A one-line hook into omarchy-setup-security-fingerprint's existing verify-failure branch, pointing at the workaround instead of just "try again" — only shown for the exact confirmed-affected id, not a general driver-quality guess.

Kept the known-id list to just 04f3:0c4b (the one I've actually verified end to end) rather than guessing at siblings — easy to extend later if others confirm the same failure mode on a different PID.

Testing

🤖 Generated with Claude Code

… setup

fprintd-verify fails with a 0 score on 04f3:0c4b under the generic
libfprint elan.c driver, with no indication that the driver is the
problem rather than technique — confirmed on a ThinkPad E15 Gen3 AMD
across 25+ verify attempts. Detect the known-risk device and, on a
verify failure, point at the workaround (Lenovo's proprietary ELAN MOH
driver via libfprint-tod) instead of just suggesting to try enrolling
again.

Detection lives in its own omarchy-hw-fingerprint-generic-driver-risk
helper, mirroring omarchy-hw-fingerprint, with unit tests against the
same OMARCHY_USB_DEVICES_PATH fixture pattern.
Copilot AI balanced review requested due to automatic review settings August 21, 2026 10:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds targeted detection and guidance for ELAN 04f3:0c4b fingerprint readers affected by generic-driver verification failures.

Changes:

  • Adds a hidden hardware-risk detector.
  • Shows workaround guidance after verification failure.
  • Adds detector tests.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
bin/omarchy-hw-fingerprint-generic-driver-risk Detects the affected USB ID.
bin/omarchy-setup-security-fingerprint Adds targeted failure guidance.
test/shell.d/hw-fingerprint-generic-driver-risk-test.sh Tests risk detection outcomes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Bwest8

Bwest8 commented Aug 31, 2026

Copy link
Copy Markdown

Additional hardware data point for this PID: IdeaPad 3 14ALC6 (LENOVO 82KT, same 04f3:0c4b) on Omarchy 4.0.2. Full writeup: #7483 (comment)

On that chassis stock elan.c never reaches verify. Enroll fails immediately:

Enroll result: enroll-disconnected

with fprintd logging a protocol error during identify-for-enroll. The hint added here is only on the verify-failure branch, so this model still gets Enrollment failed. Please try again. and no pointer at the TOD workaround.

Once libfprint-tod + libfprint-2-tod1-elan + openssl-1.1 were installed, the device showed scan-type: press as ELAN Fingerprint Sensor, enroll + verify-match succeeded, and Omarchy PAM worked.

Please also emit the 04f3:0c4b hint (or offer the TOD install, same shape as #7993) on the enroll-failure path, not only after a failed verify.

@omarchybot omarchybot added the enhancement New feature or request label Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants