Repository navigation
Route Goodix 53xc fingerprint readers to Dell's proprietary TOD driver - #7993
anupanup2001 wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Routes supported Goodix 53xc fingerprint readers through Dell’s proprietary TOD driver.
Changes:
- Adds exact hardware detection and tests.
- Adds driver preflight, consent, installation, and enrollment guidance.
- Removes TOD packages during fingerprint teardown.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-hw-fingerprint-tod |
Detects supported Goodix 53xc IDs. |
bin/omarchy-setup-security-fingerprint |
Installs and configures the proprietary driver. |
bin/omarchy-remove-security-fingerprint |
Removes TOD packages. |
test/shell.d/hw-fingerprint-tod-test.sh |
Tests exact device matching. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… drive the reader
691ef1e to
4be1f93
Compare
|
Tested the approach in this PR by hand on a Dell XPS 15 9500 (Goodix
Written with Claude Opus 5.5 via Claude Code. |
quattro's omacom#7158 replaced setup_lock_fingerprint_pam with a call to omarchy-apply-lock, next to where this branch adds setup_goodix_tod_driver. Keep the new function and drop the removed one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The removal script now also drops libfprint-tod and libfprint-goodix-53xc, and this test, added on quattro after the branch was cut, pins the exact package list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fprintd-list also fails on a permission or D-Bus error, and the pre-flight read every failure as a missing driver: a reader libfprint drives would be told no driver supports it, or on 53xc hardware offered the proprietary one. Match fprintd's own "No devices available" and leave any other failure to enrollment, as before the pre-flight. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
The open provider is removed with -Rdd before the AUR build, so a failed build left fprintd installed without libfprint. Reinstall what was removed, with --ask 4 so it also replaces libfprint-tod if that half had installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
Reviewed by Claude Opus 5.5 and, as a second opinion, Codex Medium. Codex's two findings were ones I had also reached, so its agreement doesn't count as an independent check. I pushed four commits to this branch; the head is now What was pushed
What ran On a disposable Omarchy worker with real pacman, yay and fprintd, and a fake sysfs device
No CI ran on this pull request. What is not proven The worker has no Goodix reader, so nothing here shows Dell's driver actually enrolling and verifying a finger. That rests on your Inspiron 5585 and on @timhanley testing the approach by hand on an XPS 15 9500. A confirmation from the author of the fix can't stand as verification, and you also opened #7991. If @m17kea or @timhanley can run Setup > Security > Fingerprint at What's next It waits on the maintainer: whether Omarchy should offer a closed AUR driver at all is their call (#7667 draws the same line for Lenovo's ELAN blob), and only they can confirm it on hardware. Two open pull requests overlap in this script without competing for the 53xc fix. #15080 adds a general message for readers fprintd cannot see, after a failed enrollment; #12833 keeps a TOD-provided libfprint for other vendors' blobs. Whichever lands second will need its messages reconciled with this pre-flight. |
|
The restore only ran when the AUR build returned a failure, so a Ctrl+C or a closed terminal mid-build exited setup with libfprint removed and fprintd unable to start. It now runs from an exit trap held for the whole swap, with HUP, INT and TERM turned into exits so they reach it. Each provider is recorded before it is removed, because bash runs a pending signal trap as soon as the removal returns, before any line after it. The fingerprint package test now walks the driver path itself: declining, accepting, a failed build, an interrupted build, an interrupted removal, and a rerun on the Dell driver. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
Greptile's review of What was pushed
What ran On a disposable Omarchy worker, the fingerprint setup, removal and TOD detection shell tests and What it waits on Everything else in the previous comment still stands. It waits on the maintainer, who has to decide whether Omarchy should offer Dell's closed driver at all. A worker has no Goodix reader, and the author of a fix can't confirm it, so enrollment on a real 53xc has to be confirmed by a maintainer, at |
|
The Nothing else has changed since the last comment. No new commits and no review findings have come in, and the code at this head is what that comment describes. It still waits on the maintainer, who has to decide whether Omarchy should offer the proprietary driver, and on a confirmation of enrollment on a real 53xc reader at this head. |
PR: Route Goodix 53xc fingerprint readers to Dell's proprietary TOD driver
Fixes #7991
What
Goodix
27c6:530c/533c/538creaders (Dell machines) have no open-source libfprint driver — thegoodixmocid table starts at5840. On these, the wizard detects the sensor, installsfprintd+ stocklibfprint, and thenfprintd-enrolldies instantly on "No devices available", reported to the user as "Enrollment failed. Please try again." — a failure retrying can never fix (#7991, also the 533c case from #1590).bin/omarchy-hw-fingerprint-tod— hiddenhw-helper: true when a Goodix 53xc reader is present, mirroringomarchy-hw-fingerprint'sOMARCHY_USB_DEVICES_PATHoverride for testability. Exact vid:pid match only — the same vendor's 5840+ readers are driven by the open driver and must not be steered toward a closed blob.omarchy-setup-security-fingerprint— after installing packages, askfprintd-listwhether any driver actually claimed the reader before putting a finger on glass:gum confirm --default=false, to install Dell's proprietary driver (libfprint-tod+libfprint-goodix-53xcfrom the AUR, handling theprovides+conflicts libfprintdance the script already does forlibfprint-git). Closed source installs on a yes, not silently.libfprint(provider conflict), and the enroll hint switches to press-and-hold since the 53xc is a press sensor, not a swipe sensor — scrubbing a finger it wants held still both fails stages and trips the firmware's overheat lockout (Device disabled to prevent overheating, the same self-protection behind Stop the lock screen overheating the fingerprint reader #7179), which rapid retries extend.omarchy-remove-security-fingerprint— also drops the TOD packages (omarchy-pkg-dropalready ignores names that aren't installed).PAM wiring is untouched: it comes last, only after a print is enrolled and verified, against whatever driver fprintd loaded.
Why this shape
The driver is a closed binary, so the wizard asks instead of installing silently — same line #7667 draws for Lenovo's ELAN blob, applied before enrollment rather than after a bogus verify. Keeping the known-id list to the blob's verified table (
530c,533c,538c) follows the "no guessing at siblings" approach from #7667; 5840 stays out because the open driver covers it.Testing
test/shell.d/hw-fingerprint-tod-test.sh(new), same fixture pattern ashw-fingerprint-test.sh: flags 530c/533c/538c, rejects 5840/6014/unknown pids, another vendor's 530c, and an empty bus.test/shellandtest/clisuites pass (the only failures on this machine are three pre-existing files requiring a localomarchy-pkgscheckout; they fail identically onquattroHEAD).