Repository navigation
Detect Broadcom fingerprint readers by vendor ID - #8486
gbillium143 wants to merge 1 commit into
Conversation
Broadcom (0a5c) sensors report a bare model number as their product string (e.g. "58200"), so they never match the product-name branch and the detector reports no reader present. Add 0a5c to the vendor allowlist so these devices are recognized the same way as the other vendor-only matches. Fixes omacom#8483
There was a problem hiding this comment.
Pull request overview
Adds Broadcom vendor detection so supported fingerprint readers with numeric product strings are recognized.
Changes:
- Adds Broadcom vendor ID
0a5cto the fingerprint allowlist. - Adds regression coverage for Broadcom reader detection.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-hw-fingerprint |
Recognizes Broadcom fingerprint readers by vendor ID. |
test/shell.d/hw-fingerprint-test.sh |
Tests detection with a numeric product string. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Reviewed on a disposable VM: The obvious worry about this change turns out not to fire, and that is worth saying plainly. Where it does misfire is Dell ControlVault configurations that have no fingerprint sensor. The bigger issue is what happens after detection succeeds. Stock
So the detection change is right as far as it goes, but on its own it converts "No fingerprint sensor detected" into "Enrollment failed" on a clean machine, or into a pacman conflict on a machine set up to use the reader, while also claiming some Dell machines that have no reader at all. #7993 is building vid:pid-based TOD routing that this hardware would need, and its design note argues for exact vid:pid over vendor matching for precisely this reason. Worth knowing before this lands: #7726 detects the same readers by matching On the new test: the case at On the issue links: #8483 and #8562 are the same device, Nothing pushed to your branch. Narrowing to vid:pid pairs, or holding this until TOD routing exists, is a judgement about which hardware Omarchy claims to support, and that belongs to the maintainer. Waiting on them. |
|
Looked at this again because two things have changed since the last review. The head is still 71f9fdb and nothing was run this time. This pass had only one reviewer, Opus 5.5 in Claude Code: the second opinion, Codex at medium, was not available because the bot's daily review budget is spent. A narrower competing fix now exists. #9524 fixes the same The linked issue has moved. #8483 was closed as a duplicate of #7424, so this pull request's Which detection approach to take is the maintainer's decision, so nothing was pushed here. My read is that #9524, possibly together with #7726, is the better-scoped fix. Waiting on the maintainer. |
Summary
omarchy-hw-fingerprint's vendor allowlist doesn't include Broadcom (0a5c), so Broadcom fingerprint readers are never detected — the wizard bails with "No fingerprint sensor detected" even thoughfprintd/libfprint-todfully support the device once installed.productstring (e.g."58200"), so they can't fall back to the product-name match either — they only match on vendor ID.0a5ctofingerprint_vendorsand a regression test mirroring the existing vendor-match coverage.Fixes #8483
Test plan
./test/shell.d/hw-fingerprint-test.sh— all cases pass, including the new Broadcom case./test/all— same 5 pre-existing failures as on a cleanquattrocheckout (environment-dependent: missingomarchy-pkgscheckout, sandbox permission bits,snapper/pacman DB access), unrelated to this changeidVendor=0a5c,idProduct=5843) at/sys/bus/usb/devices/3-8, previously rejected by the detector, now passes; ran the fullomarchy setup security fingerprintflow end to end (enroll, verify, PAM for sudo/polkit/lock screen) successfully with this fix applied.