Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Extends fingerprint hardware detection to inspect USB interface descriptors for composite devices.
Changes:
- Detects
fingerprintorbiometricin interface names. - Adds ControlVault detection and false-positive regression tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-hw-fingerprint |
Scans immediate USB interface names. |
test/shell.d/hw-fingerprint-test.sh |
Tests composite reader detection and generic interface rejection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Reviewed at c2704aa on a disposable Omarchy VM. No defects found. The fix is proven against a model of the hardware, but not yet on real hardware, so this waits on @eworkshop. What was run. I wrote a separate reproduction that builds a fake sysfs tree laid out like the one in #7424: Competing fixes. #8486 adds all of Broadcom's What's still open. A fake sysfs tree only shows what we believe the hardware looks like. @eworkshop, could you run this head on the Dell Pro Max 16 and say what it prints?
|
|
Updated in Validation: hw-fingerprint (25 checks), fingerprint invitation and package tests, CLI checks, shell syntax, and feature-diff whitespace checks pass. Real ControlVault hardware confirmation is still outstanding; this update does not claim that the fixture tests replace it.
|
[Medium impact] The PR appears safe to merge. SummaryExtends
No actionable issues were found. Review checks were static; tests were not run. Reviews (3) · Last reviewed commit: "Merge current quattro into fingerprint i..." · Reviewed by Greptile |
docs/file-layout.md said omarchy-hw-fingerprint finds USB readers by product string or vendor; it now also matches the name an interface gives, as on ControlVault readers whose product reads 58200. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
Reviewed again at 5021810, the merge of current What was run. On a disposable Omarchy VM, a fake sysfs tree laid out like #7424 ( Pushed. a7b704f: Second opinion. Codex Medium and muse-spark-1.3 (via pi, thinking high) both found no defect in the detection code. Both flagged the stale docs line, which is the commit above. Their independence is not guaranteed. I did not act on their smaller suggestions: a narrower glob, and matching Elan and FPC names on interfaces too. The current glob already skips everything without an Competing fixes. #8486 adds all of Broadcom's For the maintainer. Once this detects a ControlVault 3+, the menu entry and the first-run invitation appear on that machine. Setup then installs Still open. @eworkshop, could you run this head on the Dell Pro Max 16 and say what it prints?
|
|
Merged current quattro, keeping both interface-name detection and the newer Apple/platform lifecycle documentation. Fingerprint detection, invitation and package suites pass locally; full VM CI and the current Greptile check pass. Real-reader acceptance remains pending; simulated sysfs coverage is not a substitute for that check.
|
|
Reviewed again at f47e167, your merge of What was run. On a disposable Omarchy VM, a fake sysfs tree laid out like #7424 ( Second opinion. Two reviewers read it: Codex Medium, and muse-wonder via pi at high thinking. Neither found a defect in the detector, the merge or the tests. Both raised the setup problem below. They disagree on order. Codex would land this one for detection, since it is the oldest and the only one that finds For the maintainer. Once this detects a ControlVault 3+, the first-run invitation and the menu entry appear on that machine. Setup then installs Competing fixes. #16021 detects ControlVault 3 ( @eworkshop, the earlier request still stands, now at this head: A |
Problem
Some composite USB fingerprint readers expose only a generic device-level product name. The useful description appears on one of the device's USB interfaces instead.
For example, the Broadcom ControlVault 3+ (
0a5c:5865) reports58200as its product while an interface reportsBroadcom ControlVault 3+ w/FingerPrint.omarchy-hw-fingerprintcurrently reads only the product descriptor and therefore reports that no reader is present.Fixes #7424.
Change
Inspect each device's immediate USB interface descriptors for the same explicit
fingerprint/biometricidentity used by the existing product-name detection. Explicit interface names are trusted before the broader vendor heuristic; generic interfaces remain rejected.Scope
This fixes hardware detection only. Broadcom ControlVault readers may still require an out-of-tree TOD libfprint driver before enrollment can succeed, as noted in the issue. The setup flow already avoids modifying PAM unless enrollment and verification succeed.
Regression coverage
The test fixture models a composite ControlVault device with:
58200product descriptor1.01.1It verifies that every interface is searched and also confirms that the generic SmartCard interface alone does not produce a false positive.
Validation
bash test/shell.d/hw-fingerprint-test.shbash test/shell.d/fingerprint-invitation-test.shbash -n bin/omarchy-hw-fingerprint test/shell.d/hw-fingerprint-test.shshellcheck -e SC1091 bin/omarchy-hw-fingerprint test/shell.d/hw-fingerprint-test.sh./test/cligit diff --check