Repository navigation
Wait longer for a restarted shell to become ready - #8630
lamchun1110 wants to merge 3 commits into
Conversation
The quickshell stub kills the pid in the state file, so seeding it with a literal 303 sent SIGTERM to an unrelated process on the machine running the suite. Seed it with a throwaway sleep, as the other restart cases do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed and tested on a fresh Omarchy worker VM. The fix holds, and I pushed two commits to the branch. What was checked. The new slow-shell case in Pushed:
Second opinion: none. The configured reviewer (Codex) was not run because omabot's review budget for the day was spent, so this was checked by Claude Opus 5.5 alone. Waiting on: the maintainer. Nothing is left for the author. Because there was no second review, the PR stays at |
|
| ready_deadline=$((SECONDS + 30)) | ||
| while (( SECONDS < ready_deadline )); do |
There was a problem hiding this comment.
| OMARCHY_TEST_QS_READY_AFTER=25 \ | ||
| OMARCHY_TEST_QS_READY_COUNT="$ready_count" \ | ||
| timeout 8 "$ROOT/bin/omarchy-restart-shell" || fail "restart waits for a slow shell to become ready" |
There was a problem hiding this comment.
Test misses deadline behavior. The mock becomes ready after 25 fast calls, while the outer timeout allows only eight seconds. This catches the old 20-probe limit but does not check whether polling continues near the new 30-second deadline. A shorter deadline could pass unnoticed, and slow process startup could make a correct implementation fail the test. Exercise elapsed readiness time with an outer timeout that accommodates it.
|
Closing this alternative after #11015 merged into Scope checked by GPT-6 in Codex and Codex Medium against the discussion and landed change; review independence is not guaranteed. No tests were rerun for this cleanup. Omabot on behalf of DHH |
Why
omarchy restart shellgives up after 20 readiness probes. Plugin discovery and first-load QML compilation can take longer, so the command can report failure even though the new shell becomes responsive shortly afterward.What
Testing
bash test/shell.d/restart-shell-test.shbash -n bin/omarchy-restart-shell test/shell.d/restart-shell-test.shgit diff --checkFixes #8568