Repository navigation
Conversation
|
I tried this on my own system and it didn't work. I also tried this solution: https://github.com/omacom/omarchy/pull/9181/changes and it did work. So I recommend closing this PR and accepting the other one (as long as it meets your requirements) |
lockView is declared inside the per-screen WlSessionLockSurface delegate, so naming it from WlSessionLock's own onSecureStateChanged threw "ReferenceError: lockView is not defined" every time the lock became secure. The throw also aborted the handler before root.startFingerprint(), the call that starts fingerprint unlock when the fingerprint check finishes before the lock is secure. Each surface now refocuses its own field through a Connections on sessionLock, and the test checks the call sits there and not in the session lock's handler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed by Claude Opus 5.5 in Claude Code. The second opinion (Codex at medium effort) did not run: the reviewer answered its health check, but its daily review budget was spent, so nothing here has been checked by a second model. The original change threw instead of refocusing. Fixed in 7a2dc84, pushed to this branch. Each lock surface now refocuses its own password field through a What ran, on the VM:
What is not proven is the bug itself. On the VM, keyboard input reached the field after the lock became secure even without a working refocus, so the race in #9418 did not reproduce there. It was reported on an NVIDIA desktop, so it needs confirming on hardware that shows it. @work-aalp, could you test this branch at the full commit After the reboot, lock the screen and type straight away, both after a plain lock and after a resume. Please reply with your hardware and what you saw before and after. Related: #8560 is a separate open fix for focus lost across suspend. It reclaims focus in This now waits on a hardware confirmation from the reporter, then on the maintainer. |
|
The surface check sliced from WlSessionLockSurface to the end of Service.qml, so a Connections block moved out of the delegate, where lockView is out of scope, would still have passed. The slice now ends at the delegate's closing brace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed again by Claude Opus 5.5 in Claude Code, with Codex at medium effort as the second opinion, after Greptile's note on the test. Greptile's point holds, and is fixed in f618457, pushed to this branch. What ran, on a disposable VM with a real Hyprland session, with this branch merged into current
Second opinion: Codex found no defect in the change and agreed the brace-matched slice now fails if the handler is missing or moved; its agreement follows a review already written down, so its independence is not guaranteed. It added one thing worth knowing: the per-screen lock views are created when Still not proven is the bug itself. On the VM, input typed after the lock went secure reached the field with or without a refocus, so the race did not reproduce there. #9418 was closed as a duplicate of #6858, which stays open. @work-aalp, the request above still stands, now at the full commit After the reboot, lock the screen and type straight away, after a plain lock and after a resume, and reply with what you saw. Related: #8560 (focus lost across suspend) and #13907 (focus lost after a failed password) both change This waits on a hardware confirmation from the reporter, then on the maintainer. |
Summary
WlSessionLock.securebecomes true and keyboard input reaches the lock surfaceFixes #9418
Testing
bash test/shell.d/lock-focus-test.shbash test/shell.d/lock-blank-fingerprint-test.shbash test/shell.d/lock-stranded-recovery-test.shbash test/shell.d/monitor-recovery-test.shgit diff --cached --check