Check for null when calling TiffParser.checkHeader()#4429
Open
melissalinkert wants to merge 1 commit into
Open
Check for null when calling TiffParser.checkHeader()#4429melissalinkert wants to merge 1 commit into
melissalinkert wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4232.
Most calls to
checkHeaderalready check for anullreturn value, or follow a call toisValidHeaderwhich checks fornullitself. In the few remaining cases here, the changes are mostly throwing a more informative exception, or logging an error when that isn't reasonable.checkHeaderreturningnullimplies that the TIFF file is invalid, so throwing an exception of some kind is usually appropriate.This should not be a breaking change, and is not expected to have any impact on tests.