feat(collect): add error rate threshold#396
Merged
Merged
Conversation
jpmckinney
reviewed
May 6, 2025
Member
jpmckinney
left a comment
jpmckinney
left a comment
There was a problem hiding this comment.
Looks good, just one comment then can merge.
| logger.warning("%s has warnings: %s\n%s\n", self, url, "\n".join(messages)) | ||
|
|
||
| if scrapy_log.error_rate > 0.15: # 15% | ||
| raise UnexpectedError(f"The crawl had a {scrapy_log.error_rate} error rate") |
Member
There was a problem hiding this comment.
We do expect crawls to fail sometimes. (Unexpected is like the Scrapy log not existing or not being parseable, i.e. it should never happen if system is functioning normally.)
You'll need to update the import.
Suggested change
| raise UnexpectedError(f"The crawl had a {scrapy_log.error_rate} error rate") | |
| raise IrrecoverableError(f"The crawl had a {scrapy_log.error_rate} error rate") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #29