Skip to content

feat(collect): add error rate threshold #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yolile merged 2 commits into from
May 6, 2025
Merged

feat(collect): add error rate threshold #396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f00905e
feat(collect): add error rate threshold
yolile May 6, 2025
5e36f69
fix: use IrrecoverableError instead of Unexpected for kingfisher collect
yolile May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion data_registry/process_manager/task/collect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from django.urls import reverse
from scrapyloganalyzer import ScrapyLogFile

from data_registry.exceptions import ConfigurationError, RecoverableError, UnexpectedError
from data_registry.exceptions import ConfigurationError, IrrecoverableError, RecoverableError, UnexpectedError
from data_registry.models import Job, Task
from data_registry.process_manager.util import TaskManager, skip_if_not_started
from data_registry.util import CHANGE, scrapyd_url
Expand Down Expand Up @@ -144,6 +144,9 @@ def get_status(self):
url = f"https://{Site.objects.get_current().domain}{path}"
logger.warning("%s has warnings: %s\n%s\n", self, url, "\n".join(messages))

if scrapy_log.error_rate > 0.15: # 15%
raise IrrecoverableError(f"The crawl had a {scrapy_log.error_rate} error rate")

return Task.Status.COMPLETED

raise RecoverableError(f"Unable to find status of Scrapyd job {scrapyd_job_id}")
Expand Down