fix(ui): make whole Domain and Data Product rows clickable - #31876
fix(ui): make whole Domain and Data Product rows clickable#31876anuj-kumary wants to merge 3 commits into
Conversation
|
| Count | Rule |
|---|---|
| 5 | jsx-a11y/click-events-have-key-events |
| 5 | jsx-a11y/no-static-element-interactions |
| 3 | sonarjs/cyclomatic-complexity |
| 3 | react-hooks/exhaustive-deps |
| 2 | sonarjs/no-duplicate-string |
All findings
| Location | Rule | Message | |
|---|---|---|---|
| 🟡 | src/components/DataProduct/DataProductListPage.tsx:76:30 |
sonarjs/cyclomatic-complexity |
{"message":"Function has a complexity of 12 which is greater than 10 authorized.","cost":2,"secondaryLocations":[{"line":76,"column":29,"endLine":76,"endColumn" |
| 🟡 | src/components/DataProduct/DataProductListPage.tsx:148:15 |
sonarjs/no-duplicate-string |
Define a constant instead of duplicating this literal 4 times. |
| 🟡 | src/components/DataProduct/DataProductListPage.tsx:169:56 |
sonarjs/cyclomatic-complexity |
{"message":"Function has a complexity of 13 which is greater than 10 authorized.","cost":3,"secondaryLocations":[{"line":169,"column":55,"endLine":169,"endColum |
| 🟡 | src/components/DataProduct/DataProductListPage.tsx:266:5 |
react-hooks/exhaustive-deps |
React Hook useCallback has a missing dependency: 'dataProductListing.actionHandlers'. Either include it or remove the dependency array. |
| 🟡 | src/components/DataProduct/DataProductListPage.tsx:376:6 |
react-hooks/exhaustive-deps |
React Hook useMemo has missing dependencies: 'dataProductColumns' and 'dataProductListing'. Either include them or remove the dependency array. |
| 🟡 | src/components/DomainListing/DomainListPage.tsx:51:68 |
sonarjs/cyclomatic-complexity |
{"message":"Function has a complexity of 13 which is greater than 10 authorized.","cost":3,"secondaryLocations":[{"line":51,"column":67,"endLine":51,"endColumn" |
| 🟡 | src/components/DomainListing/DomainListPage.tsx:125:15 |
sonarjs/no-duplicate-string |
Define a constant instead of duplicating this literal 3 times. |
| 🟡 | src/components/DomainListing/DomainListPage.tsx:257:6 |
react-hooks/exhaustive-deps |
React Hook useMemo has missing dependencies: 'domainColumns' and 'domainListing'. Either include them or remove the dependency array. |
| 🟡 | src/components/common/atoms/domain/ui/domainFieldRenderers.test.tsx:27:5 |
jsx-a11y/click-events-have-key-events |
Visible, non-interactive elements with click handlers must have at least one keyboard listener. |
| 🟡 | src/components/common/atoms/domain/ui/domainFieldRenderers.test.tsx:27:5 |
jsx-a11y/no-static-element-interactions |
Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs |
| 🟡 | src/components/common/atoms/domain/ui/domainFieldRenderers.test.tsx:62:7 |
jsx-a11y/click-events-have-key-events |
Visible, non-interactive elements with click handlers must have at least one keyboard listener. |
| 🟡 | src/components/common/atoms/domain/ui/domainFieldRenderers.test.tsx:62:7 |
jsx-a11y/no-static-element-interactions |
Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs |
| 🟡 | src/components/common/atoms/domain/ui/domainFieldRenderers.test.tsx:73:12 |
jsx-a11y/click-events-have-key-events |
Visible, non-interactive elements with click handlers must have at least one keyboard listener. |
| 🟡 | src/components/common/atoms/domain/ui/domainFieldRenderers.test.tsx:73:12 |
jsx-a11y/no-static-element-interactions |
Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs |
| 🟡 | src/components/common/atoms/domain/ui/useDomainTableColumns.test.tsx:31:5 |
jsx-a11y/click-events-have-key-events |
Visible, non-interactive elements with click handlers must have at least one keyboard listener. |
| 🟡 | src/components/common/atoms/domain/ui/useDomainTableColumns.test.tsx:31:5 |
jsx-a11y/no-static-element-interactions |
Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs |
| 🟡 | src/components/common/atoms/domain/ui/useDomainTableColumns.test.tsx:72:7 |
jsx-a11y/click-events-have-key-events |
Visible, non-interactive elements with click handlers must have at least one keyboard listener. |
| 🟡 | src/components/common/atoms/domain/ui/useDomainTableColumns.test.tsx:72:7 |
jsx-a11y/no-static-element-interactions |
Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs |
Fix locally (fast - only checks files changed in this branch):
make ui-checkstyle-changed
✅ Playwright Results — workflow succeededValidated commit ✅ 754 passed · ❌ 0 failed · 🟡 2 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 49m 17s ⏱️ Max setup 4m 14s · max shard execution 16m 47s · max shard-job elapsed before upload 20m 20s · reporting 6s 🌐 216.79 requests/attempt · 2.72 app boots/UI scenario · 19.96% common-shard skew Optimization targets still in progress:
🟡 2 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ Approved 1 resolved / 1 findingsMakes the entire Domain and Data Product rows clickable by passing navigation callbacks into the name-cell renderers, addressing the double-firing navigation finding. ✅ 1 resolved✅ Bug: Name-cell onClick may double-fire with row onAction navigation
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
|



Describe your changes:
Fixes #31874
On the Domain and Data Product list pages, clicking a row was supposed to open that item's details page, but clicking on the name (or the area around it) did nothing, so the row felt only partly clickable.
Screen.Recording.2026-08-21.at.2.40.23.PM.mov
Screen.Recording.2026-08-21.at.2.41.55.PM.mov
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Greptile Summary
This follow-up completes the row-click navigation fix for Domain and Data Product listings.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Reviews (3): Last reviewed commit: "Added unit test for the fix" | Re-trigger Greptile