fix(ui): make whole Domain and Data Product rows clickable #31876
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Copyright 2024 Collate. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| import { fireEvent, render, screen } from '@testing-library/react'; | ||
| import { ReactNode } from 'react'; | ||
| import { Domain } from '../../../../../generated/entity/domains/domain'; | ||
| import { renderDomainNameCell } from './domainFieldRenderers'; | ||
|
|
||
| jest.mock('@openmetadata/ui-core-components', () => ({ | ||
| Avatar: () => <span data-testid="avatar" />, | ||
| Box: ({ | ||
| children, | ||
| onClick, | ||
| }: { | ||
| children: ReactNode; | ||
| onClick?: () => void; | ||
| }) => ( | ||
| <div data-testid="name-cell" onClick={onClick}> | ||
|
Check warning on line 27 in openmetadata-ui/src/main/resources/ui/src/components/common/atoms/domain/ui/domainFieldRenderers.test.tsx
|
||
| {children} | ||
| </div> | ||
| ), | ||
| Typography: ({ children }: { children: ReactNode }) => ( | ||
| <span>{children}</span> | ||
| ), | ||
| })); | ||
|
|
||
| jest.mock('../../../../../utils/TooltipUtils', () => ({ | ||
| renderBreakableTooltip: (value: string) => value, | ||
| })); | ||
|
|
||
| const DOMAIN = { | ||
| id: 'domain-id', | ||
| name: 'engineering', | ||
| displayName: 'Engineering', | ||
| fullyQualifiedName: 'engineering', | ||
| } as Domain; | ||
|
|
||
| describe('renderDomainNameCell', () => { | ||
| it('navigates once when the name cell is clicked', () => { | ||
| const onClick = jest.fn(); | ||
|
|
||
| render(<>{renderDomainNameCell(DOMAIN, onClick)}</>); | ||
| fireEvent.click(screen.getByText('Engineering')); | ||
|
|
||
| expect(onClick).toHaveBeenCalledTimes(1); | ||
| }); | ||
|
|
||
| it('stops the click from bubbling to the row so navigation is not duplicated', () => { | ||
| const onClick = jest.fn(); | ||
| const rowClick = jest.fn(); | ||
|
|
||
| render( | ||
| <div onClick={rowClick}>{renderDomainNameCell(DOMAIN, onClick)}</div> | ||
| ); | ||
| fireEvent.click(screen.getByText('Engineering')); | ||
|
|
||
| expect(onClick).toHaveBeenCalledTimes(1); | ||
| expect(rowClick).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('does not attach a click handler when no onClick is provided', () => { | ||
| const rowClick = jest.fn(); | ||
|
|
||
| render(<div onClick={rowClick}>{renderDomainNameCell(DOMAIN)}</div>); | ||
| fireEvent.click(screen.getByText('Engineering')); | ||
|
|
||
| // With no cell handler the click falls through to the row unchanged. | ||
| expect(rowClick).toHaveBeenCalledTimes(1); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /* | ||
| * Copyright 2024 Collate. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| import { fireEvent, render, renderHook, screen } from '@testing-library/react'; | ||
| import { ReactNode } from 'react'; | ||
| import { Domain } from '../../../../../generated/entity/domains/domain'; | ||
| import { useDomainTableColumns } from './useDomainTableColumns'; | ||
|
|
||
| jest.mock('react-i18next', () => ({ | ||
| useTranslation: () => ({ t: (key: string) => key }), | ||
| })); | ||
|
|
||
| jest.mock('@openmetadata/ui-core-components', () => ({ | ||
| Avatar: () => <span data-testid="avatar" />, | ||
| Box: ({ | ||
| children, | ||
| onClick, | ||
| }: { | ||
| children: ReactNode; | ||
| onClick?: () => void; | ||
| }) => ( | ||
| <div data-testid="name-cell" onClick={onClick}> | ||
| {children} | ||
| </div> | ||
| ), | ||
| Typography: ({ children }: { children: ReactNode }) => ( | ||
| <span>{children}</span> | ||
| ), | ||
| })); | ||
|
|
||
| jest.mock('../../../../../utils/TooltipUtils', () => ({ | ||
| renderBreakableTooltip: (value: string) => value, | ||
| })); | ||
|
|
||
| const DOMAIN = { | ||
| id: 'domain-id', | ||
| name: 'engineering', | ||
| displayName: 'Engineering', | ||
| fullyQualifiedName: 'engineering', | ||
| } as Domain; | ||
|
|
||
| describe('useDomainTableColumns', () => { | ||
| it('routes a name-cell click to onEntityClick with the row entity', () => { | ||
| const onEntityClick = jest.fn(); | ||
|
|
||
| const { result } = renderHook(() => | ||
| useDomainTableColumns({ onEntityClick }) | ||
| ); | ||
|
|
||
| render(<>{result.current.renderCell(DOMAIN, 'name')}</>); | ||
| fireEvent.click(screen.getByText('Engineering')); | ||
|
|
||
| expect(onEntityClick).toHaveBeenCalledTimes(1); | ||
| expect(onEntityClick).toHaveBeenCalledWith(DOMAIN); | ||
| }); | ||
|
|
||
| it('renders the name cell without a click handler when onEntityClick is omitted', () => { | ||
| const rowClick = jest.fn(); | ||
|
|
||
| const { result } = renderHook(() => useDomainTableColumns()); | ||
|
|
||
| render( | ||
| <div onClick={rowClick}>{result.current.renderCell(DOMAIN, 'name')}</div> | ||
| ); | ||
| fireEvent.click(screen.getByText('Engineering')); | ||
|
|
||
| expect(rowClick).toHaveBeenCalledTimes(1); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.