Skip to content

test(it): accept multi-select testCaseStatus[] URL in DQ dashboard pie nav (2.0) - #31881

Merged
pmbrull merged 1 commit into
2.0from
fix/dq-dashboard-multiselect-status-url-20
Aug 21, 2026
Merged

test(it): accept multi-select testCaseStatus[] URL in DQ dashboard pie nav (2.0)#31881
pmbrull merged 1 commit into
2.0from
fix/dq-dashboard-multiselect-status-url-20

Conversation

@sonika-shah

@sonika-shah sonika-shah commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

2.0 backport of #31880.

Problem

DataQualityDashboardDimensionAndPieReindexUIIT.dashboardNavigationSurvivesReindex fails on the 2.0 nightly with a 20s Playwright timeout at the Entity Health pie step.

Root cause

PR #31662 (add multi-select test case status filter, on both main and 2.0) changed BINARY_STATUS_PIE_SEGMENT_ORDER to TestCaseStatus[][]. The Entity Health pie now navigates with an array of statuses, serialized as testCaseStatus[]=Failed&testCaseStatus[]=Aborted (URL-encoded testCaseStatus%5B%5D=), not a bare testCaseStatus=. The Java IT page object still waited on the old testCaseStatus= regex → waitForURL never matched → timeout.

Fix

Widen the waitForURL pattern to accept the bare, literal-bracket, and encoded-bracket forms (testCaseStatus(%5B%5D|\[\])?=), mirroring the TS spec change that shipped in #31662. Test-only change.

Greptile Summary

This test-only backport updates the Data Quality dashboard page object to recognize single- and multi-select test-case status query parameters.

  • Accepts bare, literal-bracket, and percent-encoded bracket forms in the navigation URL.
  • Documents why Entity Health pie segments may navigate with multiple statuses.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The updated expression accepts the actual encoded multi-status query key while continuing to require the expected test-cases route and status parameter.

Important Files Changed

Filename Overview
openmetadata-integration-tests/src/test/java/org/openmetadata/playwright/ui/pages/DataQualityDashboardPage.java Correctly broadens the navigation assertion to match the URL encoding produced for multi-select status filters without weakening the route or required-parameter checks.

Reviews (1): Last reviewed commit: "test(it): accept multi-select testCaseSt..." | Re-trigger Greptile

…ard pie nav

PR #31662 made the test-case status filter multi-select and changed
BINARY_STATUS_PIE_SEGMENT_ORDER to TestCaseStatus[][]. The Entity Health pie
segment now navigates with an array of statuses, serialized with bracket array
syntax (testCaseStatus[]=Failed&testCaseStatus[]=Aborted, URL-encoded as
testCaseStatus%5B%5D=), instead of a bare testCaseStatus=. The Java IT page
object still waited on the old testCaseStatus= regex, so waitForURL never
matched and the flow timed out after 20s.

Widen the pattern to accept the bare, literal-bracket, and encoded-bracket forms
so both single- and multi-status pies satisfy the navigation contract, mirroring
the TS spec update that shipped in the same PR.
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added backend safe to test Add this label to run secure Github workflows on PRs labels Aug 21, 2026
@gitar-bot

gitar-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Widens the waitForURL regex in DataQualityDashboardDimensionAndPieReindexUIIT to support multi-select testCaseStatus[] parameters in the DQ dashboard pie nav. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@github-actions

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 87fecc6fa1c7774b6a67f420500640884f158845 in Playwright run 32474239012, attempt 1.

✅ 550 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 49m 29s

⏱️ Max setup 3m 6s · max shard execution 14m 55s · max shard-job elapsed before upload 18m 36s · reporting 6s

🌐 209.90 requests/attempt · 2.83 app boots/UI scenario · 19.78% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 19.78% (convergence target: at most 15%).
  • Browser traffic was 209.9 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.83 per UI scenario (1623 boots / 573 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 101 0 0 0 0 0
✅ Shard chromium-02 109 0 0 0 0 0
🟡 Shard chromium-03 98 0 1 0 0 0
✅ Shard chromium-04 90 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0
🟡 1 flaky test(s) (passed on retry)
  • Pages/Entity.spec.tsDelete Table (shard chromium-03, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@pmbrull
pmbrull merged commit 80215bf into 2.0 Aug 21, 2026
105 of 108 checks passed
@pmbrull
pmbrull deleted the fix/dq-dashboard-multiselect-status-url-20 branch August 21, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants