Repository navigation
adding cmeel based pip installation - #247
Conversation
|
Thank you for sharing this! I will try find some time in the next few days to try this out. BTW the ROS Rolling job is known to be failing because the official ROS Docker image hasn't cut over to Ubuntu 26.04 now. |
|
So I just tried the same with |
|
Oops sorry I made a couple of changes after opening the PR so that I can publish to pypi with a different name. You can either try to install from a previous commit (05db7d4), or just remove the "roboplan" package name in the install command since the package name on my branch was renamed to roboplan-dimos. |
|
oh wow, yes -- confirming that removing the |
|
Review-wise, I think I'm a little terrified to put so many custom shell scripts and What I'm thinking right now is: what if we make a separate repository in the It seems complicated, but it's one way we can explore not sticking a ton of files into here... thoughts? |
Hey tried to cleanup a bit so patches don't spam up original cmake files. I think it's better to just keep everything together to make release easier. With the current release ci file, new pypi packages will be built and published automatically whenever you create a new release on github. If you still prefer using a separate repo I'm also happy to help :) |
sea-bass
left a comment
There was a problem hiding this comment.
It does make sense to keep it all together if possible! Will take another look when I can.
|
hi @sea-bass , addressed your concerns. also updated package names to target
after this and the branch is merged. whenever you create a new release on github the release flow will run and publish automatically. |
scastro-nasa
left a comment
There was a problem hiding this comment.
Thanks, you're right that this is trending in a good direction where we can have the packaging in here. I left some small comments throughout, but have 3 major ones to look at:
- We don't use
vX.Y.Ztagging, it's justX.Y.Z, so these rules will have to change. - Should we be continuously testing that the PyPi packaging doesn't get broken? I think it will be very easy to break with changes. I'm thinking maybe the packaging CI job runs with every PR, but then it doesn't publish to
testpypiorpypi; it just stops at running the tests. - Are some of these variables like
BUILD_STANDALONE_PYTHON_BINDINGSandBUILD_CMEELever turned off in these scripts? If not, can we just remove them?
|
ugh I accidentally used my work account. sorry |
|
it might be the case that macOS x86 doesn't really have any github active runners. Probably pretty OK to remove that since all modern macs use M series chips (which are ARM) |
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Co-authored-by: cc <55869557+TomCC7@users.noreply.github.com>
There was a problem hiding this comment.
@TomCC7 I just went through the local testing and made a few changes, and this seems good to go. Local build and test worked, and I added a few more README instructions to get an example running.
Also added a PyPi trusted publisher re: your instructions, so that should be set once we queue up a 0.5.0 release. Though I may tag a dummy version for now just to test it.
Finally, THANK YOU for doing this very unglamorous task. This is great. I'd be happy to hear how you guys are using this library for dimensionalOS some time.
|
Glad to help! We've done some benchmarking and get a very positive result on roboplan. Can share more thoughts once we use roboplan extensively for a while! |
|
ok I got an example version of RoboPlan on here: https://pypi.org/project/roboplan/ I installed it and had to clear 2 issues. First, I had issues with my host's I was able to resolve this by creating a symlink: Secondly, I got errors again importing Pinocchio due to my having NumPy 2.5.0 installed. But when I downgraded to NumPy 1.2.6, I was able to run an example! EDIT: If I install it in a clean |
Thanks for the awesome project! Here is a fully vibed but working solution that makes the project pip installable (related to #101 ). Can try and test directly:
uv pip install 'roboplan @ git+https://github.com/TomCC7/roboplan'which will pull and build the python binding from source.
Hope this can be a good reference!