Repository navigation
ci: change Python stub generation from imperative to declarative - #296
Closed
EzraBrooks wants to merge 2 commits into
Closed
EzraBrooks wants to merge 2 commits into
EzraBrooks wants to merge 2 commits into
Conversation
Collaborator
Author
EzraBrooks
force-pushed
the
hoist-python-stubgen-ci-logic
branch
from
September 3, 2026 15:53
571c8ab to
4a56d69
Compare
Make the contents of the job clear in its name and remove inline YAML logic.
EzraBrooks
force-pushed
the
hoist-python-stubgen-ci-logic
branch
from
September 3, 2026 16:06
46dba6f to
ec00096
Compare
Merged
sea-bass
approved these changes
Sep 3, 2026
sea-bass
left a comment
sea-bass
left a comment
Collaborator
There was a problem hiding this comment.
I think this is more legible -- thanks!
Comment on lines
+72
to
+73
| - ros_distro: humble | ||
| generate_python_stubs: "OFF" |
Collaborator
There was a problem hiding this comment.
can we add a comment explaining that we're not generating stubs here because the nanobind version on ubuntu 22.04 is pre-2.0 and therefore does not have tje stubgen feature?
Collaborator
Author
|
merged into #299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YAML is not a programming language
which sounds like something the community would make up a tongue in cheek acronym for.. YINAPL?