Optimize executable discovery and fix MATLAB versioning#416
Open
samarkanov wants to merge 1 commit intoopen-research:masterfrom
Open
Optimize executable discovery and fix MATLAB versioning#416samarkanov wants to merge 1 commit intoopen-research:masterfrom
samarkanov wants to merge 1 commit intoopen-research:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the executable discovery logic to support custom paths, see the issue #415
Changes:
can_handle(path, script_file)class method to the Executable base class to allow identifying the correct subclass before instantiation.get_executable()to use a discovery-first approach: iterate through registered types and callcan_handle()to find the most specific subclassMatlabExecutable._get_version()to useself.path.RExecutable.executable_namesto be a consistent tuple ('Rscript',)os.remove("test_file.yml")to thetearDown()method intest/unittests/test_parameters.py