Repository navigation
chore: adopt shared agent rules and rollout step a - #26
Conversation
Signed-off-by: Alex Reznichenko <info@botshare.ai>
Signed-off-by: Alex Reznichenko <info@botshare.ai>
Signed-off-by: Alex Reznichenko <info@botshare.ai>
Signed-off-by: Alex Reznichenko <info@botshare.ai>
Issue #6 is closed and main 87ab8a9 has a passing tools/verify.sh run (37936438992); record that instead of the PR #16 run, list the register entries whose scope covers this repository, and name the concrete step (b) gap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LuBMxdUtyE7hPaejkyT5pe Signed-off-by: BotshareAI <botshare.ai@gmail.com>
|
adopt |
KARTHIKEYAN124
left a comment
There was a problem hiding this comment.
Reviewed head 4f6f5f6. The shared rules match canonical v2 verbatim, CLAUDE.md correctly references AGENTS.md, and the organization PR template exists. The repository-specific verification guidance matches tools/verify.sh; the recorded main-branch verification run passed. Required checks are green, and remaining harness rollout work is explicitly documented. No blocking findings for this documentation/configuration change.
panthera-momagdii
left a comment
There was a problem hiding this comment.
Approved for rollout step (a), documentation/repository guidance only.
Reviewed snapshot: openAMRobot/openamrobot-interfaces, branch chore/rollout-step-a-2026-10-17, head 4f6f5f6146a31dab9f824d88f4d50c48d5ac4b60, base 87ab8a936c97ab55ee74b8988ca3d7659160ea6a. Expected outcome: approve these four documentation/template changes, with no runtime or settings changes.
I checked all four file patches, the canonical shared-rules v2 text, the organization template location, and the existing tools/verify.sh. The shared block matches the canonical text; CLAUDE.md is the one-line import; the local template removal is consistent with using the organization template. The repository-specific verification description matches the actual gate. STATE.md keeps C10 and the remaining harness rollout steps explicitly unfinished.
I also checked the recorded main run 37936438992: it succeeded on 87ab8a9. For this PR head, ROS 2 Jazzy run 38986085253 completed its quality/build job, including Verify interfaces and consumers, successfully; Repository quality 38986085591 and license/cla are successful. Evans's adopt comment and Karthikeyan's current-head review are recorded.
No blocking finding in this scope. Harness pinning/enforcement and any C10 acceptance remain separate work; this does not validate the whole robot. Source and hosted-CI review assisted by ChatGPT at Mohamed's request. No local ROS/DDS test, code change, merge or settings change performed.
Summary
Rollout step (a) for
openAMRobot/openamrobot-interfaces(pilot), documentation and repository configuration only:AGENTS.md: canonical shared rules v2 block unchanged, then an interfaces-specific section;CLAUDE.md: the single line@AGENTS.md;STATE.md: current work, main-branch verification evidence, register scope and known gaps;.github/PULL_REQUEST_TEMPLATE.mdremoved so the organization template applies.Work package
Harness rollout step (a),
rollout/README.mdin openAMRobot/.github. Pilot repository; steps (b) to (e) are separate PRs.Integration Gate
Reused
agent-rules/SHARED_RULES.mdverbatim. Repository-specific guidance derived from README.md, CONTRIBUTING.md and docs/verification.md. Local PR template removed rather than aligned. No overlap with draft PR #25 (C10).Tests
No behaviour change. Drift check PASS (v2), adoption check PASS, Watchdog: 0 decisions, 0 public-extract, 0 shared-rules findings (3 unpinned actions, step b). CI on this branch: ROS 2 Jazzy
quality/buildandrepository-qualitygreen.Evidence
Base SHA: 87ab8a9
Head SHA: 4f6f5f6
Harness tools run from openAMRobot/.github main at 3e26c10.
Dependencies
None.
Safety impact
None.
STATE.md
Added.
Not verified
No ROS, DDS, hardware, safety or production-acceptance test is claimed for this documentation-only change. Harness pinning, warn-only, enforcement and required checks remain for steps (b) to (e).
AI disclosure
Codex prepared the draft from the repository documentation and the canonical rules. Claude Code (Claude Opus 5.5) corrected STATE.md (main-branch verification run, closed issue #6, register scope, step b gap), rewrote this description in the organization format and ran the checks above.
Contribution terms
https://claude.ai/code/session_01LuBMxdUtyE7hPaejkyT5pe
Generated by Claude Code