Skip to content

chore: adopt shared agent rules and rollout step a - #26

Merged
BotshareAI merged 5 commits into
mainfrom
chore/rollout-step-a-2026-10-17
Oct 22, 2026
Merged

BotshareAI merged 5 commits into
mainfrom
chore/rollout-step-a-2026-10-17

Conversation

@BotshareAI

@BotshareAI BotshareAI commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Rollout step (a) for openAMRobot/openamrobot-interfaces (pilot), documentation and repository configuration only:

  • AGENTS.md: canonical shared rules v2 block unchanged, then an interfaces-specific section;
  • CLAUDE.md: the single line @AGENTS.md;
  • STATE.md: current work, main-branch verification evidence, register scope and known gaps;
  • .github/PULL_REQUEST_TEMPLATE.md removed so the organization template applies.

Work package

Harness rollout step (a), rollout/README.md in openAMRobot/.github. Pilot repository; steps (b) to (e) are separate PRs.

Integration Gate

Reused agent-rules/SHARED_RULES.md verbatim. Repository-specific guidance derived from README.md, CONTRIBUTING.md and docs/verification.md. Local PR template removed rather than aligned. No overlap with draft PR #25 (C10).

Tests

No behaviour change. Drift check PASS (v2), adoption check PASS, Watchdog: 0 decisions, 0 public-extract, 0 shared-rules findings (3 unpinned actions, step b). CI on this branch: ROS 2 Jazzy quality/build and repository-quality green.

Evidence

Base SHA: 87ab8a9
Head SHA: 4f6f5f6

python3 tools/check_agent_rules.py --canonical agent-rules/SHARED_RULES.md --root .. --file ../openamrobot-interfaces/AGENTS.md   # PASS (v2)
python3 tools/check_agent_adoption.py --repositories rollout/repositories.yaml --repository openamrobot-interfaces --root ../openamrobot-interfaces   # PASS
python3 tools/watchdog.py --root ../openamrobot-interfaces --repository openamrobot-interfaces --report-only   # 0/0/0 findings, 3 unpinned actions

Harness tools run from openAMRobot/.github main at 3e26c10.

Dependencies

None.

Safety impact

None.

STATE.md

Added.

Not verified

No ROS, DDS, hardware, safety or production-acceptance test is claimed for this documentation-only change. Harness pinning, warn-only, enforcement and required checks remain for steps (b) to (e).

AI disclosure

Codex prepared the draft from the repository documentation and the canonical rules. Claude Code (Claude Opus 5.5) corrected STATE.md (main-branch verification run, closed issue #6, register scope, step b gap), rewrote this description in the organization format and ran the checks above.

Contribution terms

  • Every commit is signed off under the DCO.
  • I am covered by an accepted Contributor Agreement.
  • Third-party material is identified with source and licence.
  • No confidential, personal, credential or export-controlled information is included.
  • No partner, customer or private person is named; the application is Use_Case_1.

https://claude.ai/code/session_01LuBMxdUtyE7hPaejkyT5pe


Generated by Claude Code

BotshareAI and others added 5 commits October 17, 2026 01:53
Signed-off-by: Alex Reznichenko <info@botshare.ai>
Signed-off-by: Alex Reznichenko <info@botshare.ai>
Signed-off-by: Alex Reznichenko <info@botshare.ai>
Signed-off-by: Alex Reznichenko <info@botshare.ai>
Issue #6 is closed and main 87ab8a9 has a passing tools/verify.sh run (37936438992);
record that instead of the PR #16 run, list the register entries whose scope covers
this repository, and name the concrete step (b) gap.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LuBMxdUtyE7hPaejkyT5pe
Signed-off-by: BotshareAI <botshare.ai@gmail.com>
@Evans-Kwashie

Copy link
Copy Markdown

adopt

@Evans-Kwashie
Evans-Kwashie marked this pull request as ready for review October 17, 2026 01:41

@KARTHIKEYAN124 KARTHIKEYAN124 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head 4f6f5f6. The shared rules match canonical v2 verbatim, CLAUDE.md correctly references AGENTS.md, and the organization PR template exists. The repository-specific verification guidance matches tools/verify.sh; the recorded main-branch verification run passed. Required checks are green, and remaining harness rollout work is explicitly documented. No blocking findings for this documentation/configuration change.

@panthera-momagdii panthera-momagdii left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for rollout step (a), documentation/repository guidance only.

Reviewed snapshot: openAMRobot/openamrobot-interfaces, branch chore/rollout-step-a-2026-10-17, head 4f6f5f6146a31dab9f824d88f4d50c48d5ac4b60, base 87ab8a936c97ab55ee74b8988ca3d7659160ea6a. Expected outcome: approve these four documentation/template changes, with no runtime or settings changes.

I checked all four file patches, the canonical shared-rules v2 text, the organization template location, and the existing tools/verify.sh. The shared block matches the canonical text; CLAUDE.md is the one-line import; the local template removal is consistent with using the organization template. The repository-specific verification description matches the actual gate. STATE.md keeps C10 and the remaining harness rollout steps explicitly unfinished.

I also checked the recorded main run 37936438992: it succeeded on 87ab8a9. For this PR head, ROS 2 Jazzy run 38986085253 completed its quality/build job, including Verify interfaces and consumers, successfully; Repository quality 38986085591 and license/cla are successful. Evans's adopt comment and Karthikeyan's current-head review are recorded.

No blocking finding in this scope. Harness pinning/enforcement and any C10 acceptance remain separate work; this does not validate the whole robot. Source and hosted-CI review assisted by ChatGPT at Mohamed's request. No local ROS/DDS test, code change, merge or settings change performed.

@BotshareAI
BotshareAI merged commit d048fb8 into main Oct 22, 2026
5 checks passed
@BotshareAI
BotshareAI deleted the chore/rollout-step-a-2026-10-17 branch October 22, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants