Repository navigation
Build rc.1 from pinned commit SHAs with verified checksums (OA-05) - #12
Open
KARTHIKEYAN124 wants to merge 5 commits into
Open
KARTHIKEYAN124 wants to merge 5 commits into
KARTHIKEYAN124 wants to merge 5 commits into
Conversation
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
KARTHIKEYAN124
force-pushed
the
release/oa05-rc1
branch
from
October 24, 2026 14:58
58ce4a2 to
2a337c5
Compare
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
Contributor
|
Adopt. Maintainer re-run at aa69c80: 28/28 tests, two fresh fetch builds give the identical bundle. Merge as the rc.1 candidate builder. Pins are the 19 Oct candidate snapshot and get refreshed in one PR after Gate A. |
BotshareAI
marked this pull request as ready for review
October 27, 2026 23:15
Signed-off-by: Karthikeyan <mahikarthik10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current update ? 28 October 2026
Head: 7e2d172. Adds the requested CI parity gate against openAMRobot/openamrobot-manifest main's releases/v2.0.0-rc.1.repos. The complete path/type/URL/SHA mapping must match; only governance/.github is exempt. Missing reference files and missing driver entries fail closed. No 19 October source pins or source checksums changed.
Local validation:
python -m unittest discover -s tests -vpasses 35/35;git diff --checkpasses. The comparison matches all 13 entries in manifest PR #18 and correctly rejects PR #17 alone for missing sllidar_ros2 and micro_ros_agent. Hosted pinned-release run reaches the new parity check and fails because manifest main does not yet contain releases/v2.0.0-rc.1.repos. This is the intended fail-closed behavior; the gate cannot pass until manifest #17 and #18 merge to main. Repository quality, DCO and CLA pass; navigation validation was still running at the last check. The fresh source-build steps follow the parity guard and did not run on this head.The maintainer adopted aa69c80 in the linked comment; the evidence below remains historical validation of that head. This additional requested guard changes the head and needs fresh validation/review. The PR is already ready for review. Contributor agreement and authorization declarations below remain for the contributor to answer personally.
Pin refresh remains separate until full Gate A (6 November) and upperbody #14 complete. Interfaces repinning remains separate.
Work package
Addresses OA-05: add an exact-SHA v2.0.0-rc.1 candidate source configuration alongside the merged navigation-install gate and legacy v0.0.1 builder. The release-local manifest pins 14 sources and the reviewed lock verifies SHA-256 for the manifest and every canonical source archive. The candidate snapshot remains dated 2026-10-19; final component acceptance is not claimed.
The existing build and validation commands dispatch to pinned packaging for the new configuration. Fetches target full SHAs and verify the resolved commits. Deterministic bundles record source provenance, an exhaustive file checksum inventory and an external SHA-256. Mutable refs, missing hashes, changed source bytes and checksum mismatches fail.
Integration Gate
Rebased onto main after #9 and #8 merged. Main's navigation manifest, navigation-only test config, verifier scripts/workflow, compact evidence and archive ignores are preserved. The navigation rejection checks remain in the archive-input builder; the rc.1 dispatch is added alongside them. Main's evidence byte-preservation attributes remain in place. README and RELEASE_PROCESS retain the merged release-model documentation with short pointers to RC1_RELEASE.md.
The rebase rewrote the two original PR commits, with a local backup retained. The remote update used force-with-lease guarded by the previously verified remote head 58ce4a2. Follow-up commits record combined validation and fix the fresh-fetch portability issue below. No concurrent remote changes were overwritten.
No source repository SHA, package version or contract selection was changed. The accepted interfaces contract/package-version repin and final rc.1 component selection remain separate release work. The release-local candidate includes 13 workspace repositories plus governance; final alignment with the workspace release manifest still requires review. No inaccessible work or owner adoption is asserted.
Tests
Base SHA: c39eda7
Head SHA: aa69c80
Local: 28 tests, zero failures (11 merged navigation/config/provenance tests and 17 pinned-release tests).
The lock command fetched all 14 existing SHAs afresh. Verified all configuration fields except the source checksums were unchanged, then replaced the candidate lock. The rebuilt source bundle verifies 1,841 files. Its SHA-256 is:
2c494b1d090a3c525379d32585f483d9c685d606943657c1b64991190c11d227git diff --checkpasses. Detailed historical and current evidence is in RC1_EVIDENCE.md.Portability regression found by fresh Linux CI
The initial rebased navigation gate passed, but the pinned-release fresh-fetch run failed on the interfaces source checksum. Investigation reproduced Windows core.autocrlf changing text bytes during git archive: 59 interfaces files differed only by CRLF versus LF. The old cached Linux packaging check did not test fresh exports.
Export now explicitly sets core.autocrlf=false and core.eol=lf. Checksum enforcement remains strict. The source lock was intentionally regenerated from the same SHAs; no published release was modified. A regression using opposite host autocrlf defaults fails before the fix (one test) and passes afterward; the full 28-test suite then passes. Error output now reports expected and actual source hashes.
Hosted verification on the final head
Both final-head workflows succeeded. Linux ran all 28 tests; two independent fresh fetch/builds each verified 1,841 files and produced the same 2c494b1d090a3c525379d32585f483d9c685d606943657c1b64991190c11d227 bundle hash as Windows. The navigation producer/consumer gate also passed. Repository quality, DCO and CLA pass. The shared optional quality/test job is skipped and is not counted as validation. Hosted source and navigation evidence artifacts are available in the linked runs; no GitHub Release is published.
Dependencies
Tooling adds PyYAML 6.0.3 (MIT), https://github.com/yaml/pyyaml. The source snapshot references SLAMTEC sllidar_ros2 (upstream package declares BSD; original licence retained) and micro-ROS-Agent (Apache-2.0 and upstream third-party notices) by exact SHA. No upstream code is vendored or modified. Other component provenance/licences remain in their original exports. No LICENSE, LICENSING.md, NOTICE or CODEOWNERS change.
Safety impact
Source selection, packaging, validation and documentation only. No safety implementation changes or physical hardware access. Packaging checks do not establish component or physical safety acceptance.
STATE.md
Updated with main integration, retained navigation safeguards, the line-ending correction and remaining source-selection/acceptance work.
Not verified
Final-head hosted packaging and navigation gate checks pass. Full Jazzy workspace compilation, physical driver operation, hardware/firmware acceptance, upstream build-time downloads and reproducible compiled binaries are not validated. The interfaces contract/package-version repin and final rc.1 readiness remain pending. No merge, tag or GitHub Release is performed. The PR is ready for review and was adopted by the maintainer at aa69c80; contributor agreement coverage is not asserted by the agent.
AI disclosure
OpenAI Codex prepared the original candidate implementation and this rebase, conflict resolution, regression fix, regenerated checksum lock, tests and evidence. The contributor identity matches the authenticated user's existing signed-off contributions.
Intellectual property and provenance