Repository navigation
Add opt-in protected static inference through OpenShell - #2443
freeqaz-openai wants to merge 12 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. What this changesThis PR adds optional protected static inference with current authorization, versioned Secret reads, startup enrollment, and response filtering through OpenShell. Example: An operator replaces an OpenAI source's Secret value from version 1 to version 2.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Partial Merge readiness⛔ Blocked before merge - 4 items remain Keep this PR open as useful, explicitly paused implementation work; current main does not provide its request-bound protected inference path, and no discrete introduced bug was established. Priority: P2 Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherOCC admits credential sources and revision plans; Compute and Sandbox install their enforcement configuration, while an authenticated supervisor requests credential material and send permission before returning a filtered provider response. flowchart TB
A[Agent request] --> S[OpenShell supervisor]
S --> E[OCC egress authority]
E --> I[Current IAM and revision state]
E --> K[Kubernetes Secret]
S -. required counterpart send .-> P[Inference provider]
P -. response custody .-> S
S --> E
Technical reviewBest possible solution: Complete the bounded opt-in slice on qualified fresh revisions while preserving legacy source approval semantics and keeping broader RFC work separate. Do we have a high-confidence way to reproduce the issue? This PR proposes a new capability rather than a reproducible bug; source inspection establishes its admission and authority paths without executing target code. Is this the best way to solve the issue? The implementation extends existing Driver composition and Agent lifecycle owners, uses independent IAM checks, and preserves explicit opt-in for legacy sources. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 3a65e931a305. Merge-risk optionsMaintainer options:
Provenance checked
TestingProof path: in-process harness. SecurityNeeds attention: No concrete bypass was established, but the new supervisor credential-custody boundary requires qualification against its matching supplier. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 14, 2026, 12:38 PM ET / 16:38 UTC. |
DO NOT MERGE YET — draft implementation; interface names and integration may change. Human merge required.
This draft adds an opt-in path for protected static inference through OpenShell. For an admitted request, OCC checks current authorization, resolves the current Kubernetes Secret version, and protects the provider response before the supervisor releases it to the Agent. It is the first connected slice of RFC 0020 / #1530, not the complete Egress Proxy MVP. It requires a matching OpenShell gateway and supervisor candidate; the upstream counterpart is not yet published.
Stack base: draft #2426; prerequisite: RFC #1530; selected main:
e46d3da. No merge is requested.The repository autoreview helper failed before producing a verdict. Independent source reviews found and corrected five runtime issues. The final review found no additional P0/P1/P2 issues; its one API-description correction is included. Installed enforcement remains unqualified.