Repository navigation
Conversation
… none are set The Configure Slack drawer on an Agent with its API key bound, deployed or not, said to configure model credentials in the Credentials tab before first deploy (finding 2063, dogfood D658). Every deployment needs a harness authentication source, so the Agent page now passes the drawer a notice that names the Credentials tab only while the Agent has none.
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
clawsweeper
Bot
added
clawsweeper:intake:bug
|
Codex review: needs maintainer review before merge. What this changesThe Slack drawer requests model credentials only when the Agent has no authentication source. Example: Open Edit Slack for an Agent with an API key already bound.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review This PR makes a useful, focused correction and resolves the prior Storybook finding; no actionable code defect remains. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe Agent detail page reads authentication metadata and supplies notice text to the shared channel drawer. flowchart LR
A[Agent API metadata] --> B[Agent detail page]
B --> C[Authentication presence check]
C --> D[Shared channel drawer]
D --> E[Slack setup notice]
Technical reviewBest possible solution: Keep the existing notice hook and authentication-presence check as the complete fix. Do we have a high-confidence way to reproduce the issue? Current-main source and supplied before screenshots establish the unconditional reminder; the PR reports a base-failing, head-passing browser regression, which this read-only review did not run. Is this the best way to solve the issue? The patch uses the existing presentation owner and matches the deployment prerequisite without adding state or changing credential handling. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 14a04fbb64c0. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (1 earlier review cycle)
Reviewed October 19, 2026, 10:05 PM ET / October 20, 2026, 02:05 UTC (Revision 2). |
… "first deploy" from the default
…odel authentication
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
clawsweeper
Bot
added
clawsweeper:intake:bug
Problem
Dogfood D658 (board finding 2063, low): the Configure Slack drawer on an already deployed Agent with a bound API key says "Configure model credentials in the Credentials tab before first deploy." Neither half applies to that Agent.
Change
The Agent page now passes the channel drawer its notice (the
copy.drawerNoticehook Create Agent already uses). Every deployment needs a harness authentication source (Deploy is disabled withoutagent.harnessAuth), so:Create Agent's own notice is unchanged. The drawer's fallback notice in
channels/shared-ui.mjs, now used by neither page, says "before deploying" too. No other copy changes.Verification
tests/browser/console-agent-channels.test.mjs(real controller and IAM): a keyed Agent's drawer shows only the version sentence; an Agent created withharnessAuth: nullalso gets the Credentials sentence. Fails on main (actual: '... before first deploy.'), passes with the change. Whole file 18/18.git merge-tree, conflict hunks in the touched files) for every open PR touching them (feat: add Gateway managed mode to Agent deployments #2982, feat: share discoverable Driver configuration definitions #2980, fix(console): header layout and compact Namespace selector #2977, fix(runtime): retry network, timeout and 5xx failures of the codex login and model check #2971, feat(console): show the authorized native Gateway people roster #2596, Draft implementation: managed outbound HTTPS for dedicated Gateways #2518, Add OCE policy simulation and tester for network and plugin actions #2445, feat: assign configured OpenClaw roles to Agent users #906): identical to main.Screenshots (real controller; Agent with its API key bound, Edit Slack open)
Storybook: new Components/Channels → Slack editor, no model authentication story (
auth: null) shows the long notice; the existing Slack editor story (keyed Agent) now shows the short one. Checked by loading the built frames locally.Risks
Copy only, chosen from
agent.harnessAuthas the page already reads it. An Agent whose authentication source is removed while the tab is open shows the short notice until the tab rerenders.