Repository navigation
Conversation
Right after Deploy new version the page selects the new version while the previous one is still current, and its notice called it a Historical version until the deployment completed (dogfood finding 2065). While the newest version's deployment is queued or running and it is not current, the notice now says it is deploying and becomes current only if the deployment completes. Deployment polls update the notice, and leave it untouched when unchanged.
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
clawsweeper
Bot
added
clawsweeper:intake:bug
|
Codex review: needs maintainer review before merge. What this changesThis PR labels the newest pending Agent version as Deploying and refreshes its notice as deployment state changes. Example: v2 is deploying while v1 remains the selected version.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review This PR fixes misleading deployment wording that remains on main; the earlier Storybook finding is resolved, and no actionable code defects remain. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe Agent detail console reads version history, deployment records, and the Agent's selected revision to present version notices without claiming verified runtime health. flowchart TB
A[Agent API] --> C[Agent detail console]
B[Deployment status API] --> C
C --> D[Version notice]
C --> E[Selected version summary]
Technical reviewBest possible solution: Keep the focused console fix and complete the repository-required visual evidence before merge. Do we have a high-confidence way to reproduce the issue? Current-main source and the supplied before screenshots establish the incorrect Historical notice for deploying v2 while v1 remains current; no target code was executed during this review. Is this the best way to solve the issue? The patch uses existing deployment status and rendering owners, preserves selection and serving semantics, and adds focused coverage for success and parked-tab failure. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 9ab26afcc8e2. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (1 earlier review cycle)
Reviewed October 19, 2026, 11:03 PM ET / October 20, 2026, 03:03 UTC (Revision 2). |
…ash on success A Configuration tab parked while its deployment failed came back saying Deploying; it now rereads the notice when it is shown again. On success the notice waits for the Agent reread instead of showing Historical until the version becomes current. Storybook gains the in-progress-then-current story and steps for the pending, running and failing stories. The guide sentence is shortened to keep agent-details.md within the docs word limit.
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
clawsweeper
Bot
added
clawsweeper:intake:bug
Problem
Dogfood D660 (board finding 2065, low). Right after Deploy new version, the URL selects v2 while v1 is still the current version. Until the deployment completed (~30 s), v2's Configuration tab said "Historical version · read-only admitted snapshot. Browsing it does not change the current version." beside "Selected version v1", which reads as if the new version were old and the deploy had not happened.
Change
Console only (
agents/detail.mjs); no API change.queuedorrunningand it is not the current version, its notice says "Deploying version · read-only admitted snapshot. It becomes the current version only if its deployment completes." Other versions keep "Historical version"; the current version keeps "Current version".activeRevisionId), and the summary already shows "Latest visible deployment v2 · In progress". A note there would move the overview when the deploy settles.docs/guides/console/agent-details.mdsays so in one sentence (the file is at the docs word limit).Verification
tests/browser/console-agent-deploy-again.test.mjs(real controller; v1 active, v2 admitted, v2's deployment record routed, fake clock):succeededpoll, the notice says Current version, the summary says v2, and the notice never showed Historical in between.console-agent-deploy-again.test.mjs20/20 runs (13/13 tests each) on the final sources.git merge-tree, conflict hunks in the touched files) against every open PR touching them (fix(console): show the error's own next step in the failed-deployment banner #2989, fix(console): ask for model credentials in the slack drawer only when none are set #2986, feat: add Gateway managed mode to Agent deployments #2982, feat: share discoverable Driver configuration definitions #2980, fix(console): header layout and compact Namespace selector #2977, fix(runtime): retry network, timeout and 5xx failures of the codex login and model check #2971, feat(console): show the authorized native Gateway people roster #2596, Draft implementation: managed outbound HTTPS for dedicated Gateways #2518, Add OCE policy simulation and tester for network and plugin actions #2445, feat(iam): grant the deployer exact read of the revision a deploy admits #1605, feat: assign configured OpenClaw roles to Agent users #906): identical to main.Screenshots (real controller; v2 deploying, v1 current, v2's Configuration tab)
Risks