Repository navigation
Conversation
…ration Edit current Configuration, low on a version's page, switched to the draft at the top of the page; the editor still needed an Edit Configuration click about 1,500 px below (dogfood finding 2061). The button now opens the draft with its editor open, brought to the top of the window and focused, through the same linked-view path Deploy again uses. When the draft's Configuration read is still out, the editor opens once it lands, unless the reader has moved focus.
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
…tes are refused A draft kept in its editor with unsaved edits has no Edit Configuration button, so Edit current Configuration fell back to the top of the version detail. It now focuses and scrolls to the open editor. A caller known to be refused Agent updates gets the draft without the editor opened, and the leave guard that could never fire on a version page is dropped.
clawsweeper
Bot
added
clawsweeper:intake:bug
|
Codex review: needs maintainer review before merge. What this changesThis PR makes Edit current Configuration open, focus, and scroll to the current draft’s JSON editor. Example: From version v1’s Configuration tab at 390 × 844, click Edit current Configuration.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: it fixes a concrete Console navigation problem still present on main, and no actionable code findings remain. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe Console Agent detail page turns version-navigation actions into draft views; Configuration saves continue through the existing independently authorized API. flowchart TD
A[Version Configuration tab] --> B[Edit current Configuration]
B --> C[Existing linked view intent]
C --> D[Current draft Configuration read]
D --> E[Existing JSON editor]
E --> F[Focus and scroll into view]
Technical reviewBest possible solution: Use the existing linked-view intent to reveal the current draft’s editor while preserving explicit saves and deployment. Do we have a high-confidence way to reproduce the issue? Current-main source shows navigation to the draft without opening its editor, matching the supplied before screenshots; no target code was run during this read-only review. Is this the best way to solve the issue? The patch uses the existing navigation and editor owners, preserves independent Configuration authorization, and covers delayed reads and retained edits without adding a parallel save path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 9ab26afcc8e2. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes: No label changes. Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (2 earlier review cycles)
Reviewed October 19, 2026, 11:09 PM ET / October 20, 2026, 03:09 UTC (Revision 3). |
…istory journey Saving patches the Configuration, which the API authorizes on its own, so a Configuration editor without Agent update gets the editor opened too. The revision-history journey now reads the opened editor instead of the native Configuration disclosure, and no longer clicks Edit Configuration after Edit current Configuration. The guide says the button opens the draft's editor.
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
clawsweeper
Bot
added
clawsweeper:intake:bug
Problem
Dogfood D656 (board finding 2061, low). Edit current Configuration, low on a version's Configuration tab, switched to the draft, scrolled to the top of the page and focused the heading. The editor still needed a second Edit Configuration click about 1,500 px further down.
Change
Console only (
agents/detail.mjs); no API change.data-opens="configuration-editor"so the page can find it; its behaviour is unchanged.docs/guides/console/agent-details.mdsays the button opens the draft's editor.console-agent-detail.test.mjsnow reads the opened editor instead of the native Configuration disclosure, and no longer clicks Edit Configuration after Edit current Configuration. Its immutable-snapshot, saved-value and cancel-baseline assertions are unchanged.Verification
tests/browser/console-agent-saves.test.mjs(real controller, active v1, 390x844): "Edit current Configuration opens the draft's Configuration editor in view and focused".console-agent-saves.test.mjs20/20 runs (45/45 tests each).console-agent-detail.test.mjs19/20 runs (37/37 each), plus one extra clean run. The one failed run was the headless browser failing to launch (libgbm.so.1: cannot open shared object file) in an unrelated test, a host hiccup; the library is present and every other run passed.git merge-tree, conflict hunks in the touched files) against every open PR touching them, including fix(console): call a deploying version deploying, not historical #2990 (same file, different lines): identical to main.Screenshots (Storybook Edit current Configuration, right after the click)
Risks