Repository navigation
Conversation
…et is chosen The Create Agent chooser's Start with default Preset did not say which Preset it loads, and after a Preset was chosen Use Preset stayed a secondary button while the shortcut kept the filled style (dogfood finding 2066). A hint under the shortcut names default-codex and describes the button; choosing a Preset moves the filled style to Use Preset, and clearing the choice moves it back.
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
…ed Preset read Use Preset stays disabled after a failed read, so the clickable default shortcut keeps the filled style. The hint's id follows the selector's, as other ids in this file do.
The added sentence pushed the page past the 2,500-word docs check. The page already says Start with default Preset loads default-codex, so the change is dropped.
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
Codex review: needs maintainer review before merge. What this changesThe PR names default-codex beside the default shortcut and moves primary button emphasis to Use Preset when a Preset is selected. Example: Select Research assistant in the Create Agent Preset chooser.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: it addresses a concrete chooser usability problem that remains on current main, and review found no introduced code defect. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe console chooser reads authorized Namespace Presets, collects template variables, and passes rendered settings into the existing editable Agent form. flowchart LR
A[Create Agent chooser] --> B[Namespace Preset API]
B --> C[Readable Preset summaries]
C --> A
A --> D[Selected Preset and variables]
D --> E[Template rendering]
E --> F[Editable Agent form]
Technical reviewBest possible solution: Keep the focused presentation change within the existing Preset chooser and Agent creation flow. Do we have a high-confidence way to reproduce the issue? Current-main source keeps the shortcut primary after selection and provides no adjacent default-name hint; the before screenshots show both behaviors, although no target code was executed during review. Is this the best way to solve the issue? The patch uses the existing chooser, button classes, and asynchronous response guards, making it a proportionate solution without another configuration or creation path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 33132e12df10. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 19, 2026, 11:19 PM ET / October 20, 2026, 03:19 UTC. |
Problem
Dogfood D661 (board finding 2066, low). In the Create Agent chooser:
Change
Console only (
agents/presets.mjs, one line inagents/create.mjs); no API change.aria-describedby). It shows only whendefault-codexis readable; otherwise the existing "default-codex is not available to you in this Namespace" hint applies, as before.docs/reference/console/create-and-deploy.mdalready says Start with default Preset loadsdefault-codexand is at the docs word limit, so it is unchanged.Verification
tests/browser/console-agent-presets.test.mjs(real controller, installed default-codex plus a Namespace Preset): "the Preset chooser names its default and fills Use Preset once a Preset is chosen". It checks the hint andaria-describedby, shortcut filled / Use Preset not, the swap after choosing the Preset, the swap back after clearing it, and the shortcut keeping the filled style after a failed (503) Preset read.console-agent-presets.test.mjs20/20 runs (33/33 tests each) on the final sources.git merge-tree, conflict hunks in the touched files) against every open PR touching them: identical to main except Support custom Installation profiles and readable Preset starters #2253 (custom Installation profiles), which rewrites the samedefaultIdlines to pick a starter Preset. If this lands first, Support custom Installation profiles and readable Preset starters #2253 would name itsstarterin the hint instead of default-codex.Screenshots (Storybook Preset variables, a Preset chosen)
Risks