Repository navigation
test(ci): add five duration rows and refresh console-focus-ring's - #3011
Conversation
The flake-sweep-1020 window found five shared files with no duration row, which start first in their lanes, and console-focus-ring's row at 11.1 s against about 15 s measured since #2977 grew it. Each row is the slowdown-normalised median (the table's documented method) over the green main runs whose head has the file's last change: console-namespace-create 12.3 s (8 runs), console-shell 12.8 s (2), console-page-header 8.5 s (15), console-focus-ring 15.5 s (15), credential-source-api 4.2 s (21), agent-create-validate-api 3.2 s (21).
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR adds five measured test-file durations and updates the console focus-ring estimate. Example: Scheduling console-shell.test.mjs in Console Browser
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open for maintainer triage: it is a focused refresh of CI scheduling metadata, with no blocking correctness or security finding. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe CI runner reads duration estimates and suite manifests, orders eligible shared files, and executes them within the lane's concurrency limit. flowchart LR
A[Suite manifests] --> C[CI runner]
B[Duration estimates] --> C
C --> D[Shared file ordering]
D --> E[Concurrent test execution]
E --> F[CI results]
Technical reviewBest possible solution: Keep measured scheduling estimates current within the existing table and runner. Do we have a high-confidence way to reproduce the issue? The current-main table and runner establish the missing-estimate ordering directly; no target code was executed during this read-only review. Is this the best way to solve the issue? Refreshing the existing table is appropriately scoped, although the credential-source-api estimate is currently inert because that file runs serially. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 8fe865c1649a. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 20, 2026, 1:35 AM ET / 05:35 UTC. |
Problem
The flake-sweep-1020 window (10-19 18:00Z to 10-20 04:18Z) found five shared files with no row in
file-durations.json: console-namespace-create, console-shell, console-page-header, credential-source-api and agent-create-validate-api. A file without a row starts first in its lane, ahead of longer measured files. console-focus-ring's row was 11.1 s, but #2977 grew the file and it now measures about 15 s.Change
scripts/ci/test-suites/file-durations.jsongets five new rows and one refreshed row. Each row uses the table's documented method: the slowdown-normalised median over the green main runs whose head contains the file's last change. Each run lane's factor is the median, over its files other than these six, of their time divided by their current row. Thesourcetext records this.Data: the sweep's downloaded
ci-results-<lane>artifacts from main runs in the window, plus #3000. console-namespace-create is the exception: #3002 grew it after the window, so it uses the runs listed in the table. The branch is merged with main.Verification
node scripts/ci/run-tests.mjs auditpasses. It validates the duration table along with the suite manifests.ci-runnerduration and start-order cases pass.fileConcurrencyslots, using the new times): Console Browser 88.6 s, Console Browser 2 90.3 s, Checks and Conformance 1 54.4 s, Checks and Conformance 2 56.5 s, unchanged from the old start order within 0.1 s. The new rows move the files out of the "unmeasured, start first" group: Console Browser goes from 3 unmeasured files to 1 and Console Browser 2 from 1 to 0. The one left, console-create-agent-member, landed in fix(console): let members with agent:create use the create form #2998 after the window.prettier --checkpasses.Risks