Repository navigation
RFC 0003: Sport Scoping (sport field + per-sport action vocabularies) - #36
Merged
Merged
Conversation
…f/check) for invasion sports
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…back-compat branch
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements accepted RFC 0003. Additive, backwards-compatible → v1.2.0.
Summary
sportfield (enum basketball/soccer/handball/hockey/futsal, default basketball).allOf+if/then; the pre-existing custom-rulesetif/thenis folded into the sameallOf(only one top-levelifallowed).anyOf[ sport-absent, sport==basketball ]so existing sport-less documents stay valid (JSON Schemadefaultdoesn't apply during validation).tackle/clear/faceoff/check) with no variants;action_refpattern extended.sports/basketball-v1.json(defined) + soccer/handball/hockey/futsal (v0.0.1provisional skeletons).== Sport, changelog), framing reconciled to "team-sport / invasion sports, basketball first", version → 1.2.0 in all four places, RFC 0003 marked accepted.Verified (ajv/draft-07)
custom_dimensions.$idstaysschema/v1.json(v1 major line, additive).Test Plan
npm test— 7 valid examples, 15 invalid rejected, 5 position + 3 sport testsKnown follow-up (not in this PR)
The schema caps player numbers at
nr1-9 (entity_ref_[1-9]), which fits basketball but not soccer (11) / handball (7). Raising it touches the neutral core (entity nr, entity_ref, action_ref, state patternProperties) and is a separate change — tracked as an RFC 0003 open question.🤖 Generated with Claude Code