config/convert: expose Config.Volumes as an annotation - #678
Open
jochumdev wants to merge 1 commit into
Open
Conversation
Record the same information as the org.opencontainers.image.volumes annotation, following the existing pattern used for ExposedPorts and StopSignal. Signed-off-by: René Jochum <rene@jochum.dev>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
+ Coverage 72.89% 74.14% +1.25%
==========================================
Files 71 71
Lines 6164 4634 -1530
==========================================
- Hits 4493 3436 -1057
+ Misses 1213 747 -466
+ Partials 458 451 -7
🚀 New features to boost your workflow:
|
stgraber
reviewed
Aug 17, 2026
| createdAnnotation = "org.opencontainers.image.created" | ||
| stopSignalAnnotation = "org.opencontainers.image.stopSignal" | ||
| exposedPortsAnnotation = "org.opencontainers.image.exposedPorts" | ||
| volumesAnnotation = "org.opencontainers.image.volumes" |
There was a problem hiding this comment.
I'm not seeing any reference to this in the OCI spec.
Author
|
We have another fix: lxc/incus#3860 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record the same information as the org.opencontainers.image.volumes annotation, following the existing pattern used for ExposedPorts and StopSignal.