Skip to content

config/convert: expose Config.Volumes as an annotation #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jochumdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

config/convert: expose Config.Volumes as an annotation #678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions oci/config/convert/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const (
createdAnnotation = "org.opencontainers.image.created"
stopSignalAnnotation = "org.opencontainers.image.stopSignal"
exposedPortsAnnotation = "org.opencontainers.image.exposedPorts"
volumesAnnotation = "org.opencontainers.image.volumes"

@stgraber stgraber Aug 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any reference to this in the OCI spec.

)

// ToRuntimeSpec converts the given OCI image configuration to a runtime
Expand Down Expand Up @@ -185,6 +186,7 @@ func MutateRuntimeSpec(spec *rspec.Spec, rootfs string, image ispec.Image) error
setAnnotation(createdAnnotation, ig.Created().Format(igen.ISO8601))
setAnnotation(stopSignalAnnotation, image.Config.StopSignal)
setAnnotation(exposedPortsAnnotation, strings.Join(ig.ConfigExposedPorts(), ","))
setAnnotation(volumesAnnotation, strings.Join(ig.ConfigVolumes(), ","))
// Config.Labels need to be applied after the auto-applied labels.
maps.Copy(spec.Annotations, ig.ConfigLabels())

Expand Down
Loading