Repository navigation
fix(frontend): restore the imports the #751 merges dropped - #843
Merged
Merged
Conversation
master fails npm run type-check: MembersView uses DeleteButton and CreateRiskModal uses ScrollProgress, but neither file imports them any more. Both are exported by shared/ds. The same merge left an unused useMemo import in CreateRiskModal, which eslint rejects. Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
This was referenced Sep 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #751. This does not close it: #751 is the premium UI epic, and this only repairs merge damage on master.
Problem
npm run type-checkfails onmaster:Both components are exported by
shared/ds. The imports were lost in the #751 phase merges. The same merge left an unuseduseMemoimport inCreateRiskModal.tsx, which eslint rejects (@typescript-eslint/no-unused-vars).It blocks criterion 4 of #807 (PR #832), which requires a green type-check.
Change
Three import lines, no logic change.
Verification
Honest remainders
No browser pass. This PR restores imports that the rendered code already referenced, so on master these screens currently throw a
ReferenceErrorwhen the delete button or the progress bar renders. After this PR they render again.