Skip to content

fix(frontend): restore imports lost in merge 269e54fc (#840) - #845

Merged
alex-dembele merged 1 commit into
masterfrom
fix/840-restore-lost-imports
Oct 1, 2026
Merged

alex-dembele merged 1 commit into
masterfrom
fix/840-restore-lost-imports

Conversation

@alex-dembele

@alex-dembele alex-dembele commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Closes #840

The conflict resolution in 269e54fc (Merge branch 'master' into feat/751-phase2-feedback, shipped with #823) dropped two imports:

  • DeleteButton in MembersView.tsx
  • ScrollProgress in CreateRiskModal.tsx

vite build doesn't type-check, so the build stayed green, but both screens throw on render. This PR adds the two names back to their existing shared/ds imports.

Verification

master @ 234c342c
  npx tsc -b      → 2× TS2304 (DeleteButton, ScrollProgress)
  npx vitest run  → Tests 11 failed | 849 passed

this branch
  npx tsc -b      → clean
  npx vitest run  → Test Files 87 passed (87) · Tests 873 passed (873)

The totals differ because the failing files stopped collecting some tests when they crashed.

Live

The live check ran a server built from this branch on a throwaway Postgres 16 and Redis 7, with Vite in front and Chromium via Playwright.

  • With the fix:
    • /settings/members, with a second member added through a real invitation, renders both rows and the "Révoquer l'accès de member840@example.com" button.
    • "Nouveau risque" opens the "Créer un nouveau risque" dialog.
    • No pageerror on either screen.
  • Counter-proof, with the imports removed again on the same stack:
    • ReferenceError: DeleteButton is not defined, and the members table renders 0 rows.
    • ReferenceError: ScrollProgress is not defined, and no dialog opens.

Honest remainders

  • CI did catch this: the Frontend Typecheck and Frontend Unit Tests checks were red on feat(ds): phase 2 feedback and validations motion (#751) #823 when it was merged. Most other checks on that PR were red too, so a real failure is hard to tell from the usual noise. That is worth its own look.
  • Noticed while testing and not investigated here: a member invited with role user shows "Administrateur (accès complet)" in the roster. It may be a display mapping or a real role issue, and it needs its own look.

)

The conflict resolution in 269e54f dropped both imports. vite build
does not type-check, so master shipped a members page and a create-risk
modal that throw a ReferenceError as they render.

Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
@alex-dembele

Copy link
Copy Markdown
Member Author

Duplicate of #843, which another session opened an hour earlier. It restores the same two imports, is based on the current master (with #824), and also removes an unused useMemo import.

Recommendation: merge #843 and close this PR. The live proof above, including the counter-proof with the imports removed, applies to #843 as well: both PRs add the same import lines.

@alex-dembele
alex-dembele merged commit f486e9f into master Oct 1, 2026
17 of 30 checks passed
@alex-dembele
alex-dembele deleted the fix/840-restore-lost-imports branch October 1, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(frontend): members page and create-risk modal crash — imports lost in merge 269e54fc

1 participant