Repository navigation
fix(frontend): restore imports lost in merge 269e54fc (#840) - #845
Merged
Merged
Conversation
) The conflict resolution in 269e54f dropped both imports. vite build does not type-check, so master shipped a members page and a create-risk modal that throw a ReferenceError as they render. Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
This was referenced Sep 29, 2026
Closed
Member
Author
|
Duplicate of #843, which another session opened an hour earlier. It restores the same two imports, is based on the current Recommendation: merge #843 and close this PR. The live proof above, including the counter-proof with the imports removed, applies to #843 as well: both PRs add the same import lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #840
The conflict resolution in
269e54fc(Merge branch 'master' into feat/751-phase2-feedback, shipped with #823) dropped two imports:DeleteButtoninMembersView.tsxScrollProgressinCreateRiskModal.tsxvite builddoesn't type-check, so the build stayed green, but both screens throw on render. This PR adds the two names back to their existingshared/dsimports.Verification
The totals differ because the failing files stopped collecting some tests when they crashed.
Live
The live check ran a server built from this branch on a throwaway Postgres 16 and Redis 7, with Vite in front and Chromium via Playwright.
/settings/members, with a second member added through a real invitation, renders both rows and the "Révoquer l'accès de member840@example.com" button.pageerroron either screen.ReferenceError: DeleteButton is not defined, and the members table renders 0 rows.ReferenceError: ScrollProgress is not defined, and no dialog opens.Honest remainders
Frontend TypecheckandFrontend Unit Testschecks were red on feat(ds): phase 2 feedback and validations motion (#751) #823 when it was merged. Most other checks on that PR were red too, so a real failure is hard to tell from the usual noise. That is worth its own look.usershows "Administrateur (accès complet)" in the roster. It may be a display mapping or a real role issue, and it needs its own look.