feat(iZH): integrate rule-driven antenna checking and repair into EarlyRouter - #224
Open
Ayoubbelguellaoui wants to merge 6 commits into
Open
Ayoubbelguellaoui wants to merge 6 commits into
Ayoubbelguellaoui wants to merge 6 commits into
Conversation
- Add kBoth/kSkip to AFFixKind, hopUpPermitted(), applySelected() - classify() returns kBoth for metal PAR (hop-up first, diode fallback) - AntennaEngine uses applySelected() instead of always-fallback-to-diode - Phase A-D bug fixes: incremental index, skip-net overlap, orphan cleanup, via_master_idx preservation, materialize scope, via fallback - Manhattan L-shaped diode stub routing, jog overlap check, multi-row diode site search - RoutingContext::forTest() for unit testing - 6 strategy-selector tests proving violation/rule-driven selection - test_izh_antenna_fixer and test_izh_antenna_checker pass
ZhishengZeng
requested review from
ZhishengZeng and
shuyulun01
and removed request for
ZhishengZeng
September 11, 2026 04:13
Collaborator
|
Thanks, @Ayoubbelguellaoui ! This looks like a substantial change. We may need some time to go through it. |
Author
|
Of course, reliability is what matters most ! @ZhishengZeng |
- Log touched_nets, total_signal_nets, elapsed_ms per fix iteration - Add antenna benchmark test for violation/net/timing reporting
Ayoubbelguellaoui
force-pushed
the
main
branch
from
September 14, 2026 09:38
8c03d49 to
90cb57f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves antenna violation detection and repair into iRT's EarlyRouter. EarlyRouter catches and fixes violations mid-route instead of leaving them for a separate pass to find after routing finishes.
EarlyRouter reads antenna rules from LEF/IDB and picks a repair strategy for each violation: hop-up when it's viable, diode insertion otherwise. AntennaFixer validates the repair against existing wires and vias before applying it. AntennaEngine then re-verifies only the nets that changed.
A post-routing checker only reports what already broke; this catches and repairs it while EarlyRouter still owns the route.