Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output timing checks ignored the uncertainty of the clock associated with
set_output_delay, making output setup and hold slack optimistic. Apply setup uncertainty with a negative sign and hold uncertainty with a positive sign when calculating required time. Also correct the report’s uncertainty cumulative time and output-delay increment so nonzero and negative output delays add up correctly.With the GCD case’s 0.5 ns uncertainty, TT hold violations change from 34 to 52 and SS from 34 to 41, matching the saved PrimeTime endpoint sets. Residual cell/net delay differences remain: worst setup slack differs by 1.150 ps (TT) and 1.465 ps (SS).
Validation:
ecc_binbuilds; four focused CTests pass. The new output-uncertainty regression fails before the fix and passes afterward, including separate setup/hold values, capture-clock selection, output-delay signs, and report arithmetic. Test changes remain local as requested.