Skip to content

fix(iSTA): apply clock uncertainty to output timing checks #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yipeix wants to merge 1 commit into from
+9 −3
Closed

fix(iSTA): apply clock uncertainty to output timing checks #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/operation/iSTA/source/module/timing_analyzer/TimingAnalyzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,11 +405,15 @@ double TimingAnalyzer::getEndPointRequired(std::string& start_point, std::string
Pin& pin = database.get_pin_map()[end_point];
if (pin.get_is_port()) {
std::map<std::string, TimingPortConstraint>& port_constraint_map = database.get_timing_constraint().get_port_constraint_map();
double uncertainty = getClockUncertainty(end_point, analysis_type);
double signed_uncertainty = analysis_type == AnalysisType::kMin ? uncertainty : -uncertainty;
if (analysis_type == AnalysisType::kMin && port_constraint_map.count(end_point) > 0 && port_constraint_map[end_point].get_has_output_delay_min()) {
return getEndPointCaptureTime(start_point, end_point, analysis_type) - port_constraint_map[end_point].get_output_delay_min();
return roundTime(getEndPointCaptureTime(start_point, end_point, analysis_type) - port_constraint_map[end_point].get_output_delay_min()
+ signed_uncertainty);
}
if (port_constraint_map.count(end_point) > 0 && port_constraint_map[end_point].get_has_output_delay_max()) {
return getEndPointCaptureTime(start_point, end_point, analysis_type) - port_constraint_map[end_point].get_output_delay_max();
return roundTime(getEndPointCaptureTime(start_point, end_point, analysis_type) - port_constraint_map[end_point].get_output_delay_max()
+ signed_uncertainty);
}
return default_required_time;
}
Expand Down
4 changes: 3 additions & 1 deletion src/operation/iSTA/source/module/timing_reporter/TimingReporter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,8 @@ void TimingReporter::outputRequiredClockInfo(std::ofstream* report_file, TimingP
double required_before_check = timing_path.get_required_time();
if (std::fabs(timing_path.get_check_time()) > STA_ERROR) {
required_before_check -= delay_type == DelayType::kMax ? -timing_path.get_check_time() : timing_path.get_check_time();
} else if (isPort(timing_path.get_end_point())) {
required_before_check += getOutputDelay(timing_path, delay_type);
}
outputTimingLine(report_file, "clock uncertainty", signed_uncertainty, required_before_check, true, "", label_width);
}
Expand All @@ -1452,7 +1454,7 @@ void TimingReporter::outputRequiredClockInfo(std::ofstream* report_file, TimingP
&& (port_constraint_map[timing_path.get_end_point()].get_has_output_delay_max()
|| port_constraint_map[timing_path.get_end_point()].get_has_output_delay_min());
if (has_output_delay) {
outputTimingLine(report_file, "output external delay", output_delay, timing_path.get_required_time(), true, "", label_width);
outputTimingLine(report_file, "output external delay", -output_delay, timing_path.get_required_time(), true, "", label_width);
}
}
outputTimingSummaryLine(report_file, "data required time", timing_path.get_required_time(), label_width);
Expand Down
Loading