Skip to content

fix(cli): correctly resume existing runs through rerun - #278

Open
Ayoubbelguellaoui wants to merge 5 commits into
openecos-projects:mainfrom
Ayoubbelguellaoui:main
Open

Ayoubbelguellaoui wants to merge 5 commits into
openecos-projects:mainfrom
Ayoubbelguellaoui:main

Conversation

@Ayoubbelguellaoui

Copy link
Copy Markdown
Contributor

What Changed

-chipcompiler/cli/project/run_existing.py: route existing-workspace resume through rerun.run_resume (with preserve_cli_stdio and bounded_resume_r
-test/cli/commands/conftest.py: DummyFlow.create_step_workspaces accepts kwargs
-test/cli/commands/test_flow_continuation.py: added test_stale_suffix_reexecuted_via_run_resume spy test

Scope

Select the areas touched by this PR:

  • CLI - command behavior, Typer command surface, output formats, or workspace commands.
  • Flow/runtime - workspace lifecycle, EngineFlow, step execution, logs, metrics, or artifacts.
  • EDA integration - Yosys, ECC-Tools, DreamPlace, KLayout, PDKs, or native/runtime wrappers.
  • Build/package - Nix, PyInstaller, wheels, uv.lock, or release artifacts.
  • CI/release - GitHub Actions, version checks, changelog, or release automation.
  • Tests/docs only

Runtime And Packaging Impact

  • No runtime or packaging impact
  • CLI output or machine-readable contract changed
  • Workspace layout, flow state, or artifact paths changed
  • Native toolchain or wrapper behavior changed
  • ecc-tools or ecc-dreamplace dependency changed
  • PyInstaller, Nix, or release artifact changed

Notes:

-This changes the runtime behavior of resuming existing workspaces.
-No workspace layout or artifact format is intentionally changed; the existing rerun mechanism is now used consistently by the CLI.
-No dependencies or packaging artifacts are affected.

Validation

List the commands you ran. Mark checks that are not applicable as N/A.

  • uv run pytest test/
  • uv run ruff check chipcompiler test
  • uv run ruff format --check chipcompiler test
  • PyInstaller smoke: ecc --help, ecc --version, ecc version --json
  • Nix smoke: nix run .#cli -- --help
  • Manual flow smoke:
  • Other:

Skipped checks and reason:

Checklist

  • I kept the change scoped to ECC.
  • I updated docs or user-facing CLI text where behavior changed.
  • I included lockfile or version metadata updates when dependencies changed.
  • I documented any submodule updates and why they are needed.
  • I did not include local caches, virtual environments, or generated build outputs.
  • I explained skipped validation and remaining risk.

Verify that AgentEngineFlow.run_step() executes the tool even when the
step log path is unusable (e.g. a directory), and that a failing tool
still becomes Incomplete without leaving any step stuck in Ongoing.
@Emin017 Emin017 added the bug Something isn't working label Sep 14, 2026
@Emin017 Emin017 added this to the 0.1.0-alpha.13 milestone Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants