Repository navigation
feat: label component pods for status.components - #45
Merged
Merged
Conversation
recharte
force-pushed
the
feat/label-component-pods
branch
from
October 6, 2026 19:16
9712153 to
5cac6e2
Compare
Grants list and watch on pods and sets Context.PodLabels on the instance and PgBouncer pods. Signed-off-by: Diogo Recharte <diogo.recharte@solanica.io>
recharte
force-pushed
the
feat/label-component-pods
branch
from
October 7, 2026 09:12
5cac6e2 to
088db31
Compare
recharte
marked this pull request as ready for review
October 7, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labels each component's pods so the provider runtime reports them on the Instance: pod counts in
status.components(openeverest/openeverest#3335) and thePodsScheduled/PodsReadyconditions (openeverest/openeverest#3312).listandwatchon pods to report them. The pods marker was only an example comment, so this addsget,listandwatch.make generatesyncs the rule toconfig/rbacand the chart.labelPodsputsc.PodLabels(component)onspec.instances[].metadata.labels(engine) andspec.proxy.pgBouncer.metadata.labels(proxy). The operator merges these into the pod templates only. The instance StatefulSet and PgBouncer Deployment selectors keep the operator's own labels, so existing clusters roll once and keep their selectors.Notes
go.modpins coremain(da37bb3), which includes feat: report unschedulable and failing pods as Instance conditions openeverest#3312 and theComponentSpec.nameremoval from refactor(api): drop ComponentSpec.name openeverest#3337 (no provider used it).Testing
make test-unit,make lint(0 issues),make generate.core/clusternow asserts the labels on the instance set and PgBouncer specs of the PerconaPGCluster. It also checks that the Instance reportsengineandproxywith their selectors and0/0pods (the operator is scaled to 0 there). With no pods, thePodsScheduledandPodsReadyconditions would beTruewhatever the runtime did, so they are not asserted; their logic is unit-tested in core.