Repository navigation
Conversation
added 5 commits
October 30, 2026 23:11
…bases on register
florent37
commented
Oct 30, 2026
florent37
marked this pull request as ready for review
October 30, 2026 22:45
florent37
enabled auto-merge (squash)
October 30, 2026 22:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Logs screen of a database stayed empty while the same queries were visible in the timeline: the logs were stored under the name the app gave to
floconLogs(name = ...)(cats), and the screen filtered with the name displayed in the sidebar (cats (Room 2)). The databaseidis now the only identifier used for the database protocol methods (get_databases,query,log_query); the name is only a label.register(id, displayName, database)(Room and Room 3) takes a requiredid, and the plugin refuses a second database registered with the same id (IllegalArgumentException; registering the same database twice is fine).floconLogs(id = ...)replacesfloconLogs(name = ...),logQuery(dbId, ...)replaceslogQuery(dbName, ...). The no-op modules and the samples follow.log_querysendsdbId(required) instead ofdbName. Breaking, on purpose: the v2 SDK is not published yet.protocol/database.mdupdated.dbId(Logs screen, page count, exports, MCPlist_database_query_logs, timeline). The Room schema goes to version 90 (destructive migration already configured: the previous logs are dropped). A log withoutdbIdis no longer supported.docs2/database.mdanddocs2/migration.md.docs/database.mdstill documents the oldfloconRegisterDatabaseAPI and is left as is.Tested:
:database:core:jvmTest, desktop:mcp:allTests,:data:remote:allTests,:data:local:allTests,:data:core:allTests, ktlint, debug and release builds of:sample:android. Checked with the desktop app and the Android sample: the logs ofcats (Room 2)arrive withdbIdand are returned bylist_database_query_logs. The iOS sample was not built./gemini review