Repository navigation
test(geolibre): mark the langpack test wait; run test-hygiene on every PR - #2323
Conversation
The removal test added in #2289 sleeps to show remove() stays blocked while a check holds LIFECYCLE. test-hygiene requires a // test-wait: reason on timer waits, so CI failed on main on every platform.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The test job runs only the packages a pull request changes, so xtask's hygiene test missed the new sleep in #2289 and main failed.
Code reviewI found no defects in this PR and left no inline comments. There were no earlier review threads, so no concerns were left alone as already raised. What I checked:
Confidence: high that the change is correct and that there is nothing to raise. Bugs: none. Change sizeCompared: the whole PR against main (merge base 55e1ede to PR head eec18bb).
|
📖 Docs preview
GitHub Pages takes a minute or two to publish a new commit. |
Fixes CI on main (run 44008397027):
xtask test_hygiene::tests::repository_tests_follow_the_guardrailsfailed on every platform withCause: #2289 added a test that sleeps 200 ms to show
remove()stays blocked while a check holdsLIFECYCLE. Its merge-queue run (44005866127, same commit) passed because thetestjob runs only the packages a change touches (test-selection.shpickedrustgis-geolibreand its dependents, notxtask), and test-hygiene runs nowhere else on a pull request. The push to main runs every package, so it failed there.Fix:
// test-wait:reason the check asks for.Project schemajob, which already builds xtask and runs whole on every pull request, now also runscargo xtask test-hygiene, so a new wait in any package is caught before it merges.Evidence:
cargo xtask test-hygieneandcargo test -p xtask repository_tests_followpass locally; the new CI step runs on this PR.Reaches: tests and CI only, no surface changes.
Summary by CodeRabbit