Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,11 @@ jobs:
# to the schema alone is checked against them too.
- name: Validate the fixture projects against the schema
run: pipx run check-jsonschema==0.39.0 --schemafile schema/project.schema.json --default-filetype json schema/fixtures/*.rgis
# Timer waits and ignored tests carry their reasons. xtask's own test checks this too, but
# `test` runs only the packages a pull request changes, so a new wait elsewhere got past it
# and failed main (#2289). This runs on the whole workspace every time.
- name: Test hygiene
run: cargo run --locked -q -p xtask -- test-hygiene

# The packages whose tests this run needs, for `test` (.github/scripts/test-selection.sh). Only
# tests are narrowed: lint, the wasm build, licences and the schema check run whole every time.
Expand Down
2 changes: 1 addition & 1 deletion crates/geolibre/src/langpack.rs
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ mod tests {
// record an error for a pack already gone.
let check = LIFECYCLE.lock().unwrap();
let removal = std::thread::spawn(|| remove("fr"));
std::thread::sleep(std::time::Duration::from_millis(200));
std::thread::sleep(std::time::Duration::from_millis(200)); // test-wait: proves remove() stays blocked while a check holds LIFECYCLE; no signal marks a blocked call
assert!(!removal.is_finished(), "remove ran during a check");
drop(check);
removal.join().unwrap().unwrap();
Expand Down
Loading