[SES-PHASE-1-8] - PLU-744: add bounce rate tracking (exploration)#1634
Open
m0nggh wants to merge 1 commit into
Open
[SES-PHASE-1-8] - PLU-744: add bounce rate tracking (exploration)#1634m0nggh wants to merge 1 commit into
m0nggh wants to merge 1 commit into
Conversation
This was referenced May 20, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
b152844 to
fcf855e
Compare
d24c3a0 to
a60b320
Compare
ogp-weeloong
reviewed
Jun 6, 2026
| }), | ||
| }), | ||
| ) | ||
| incrementMetric('ses.email.sent') |
Contributor
There was a problem hiding this comment.
nit: technically we can avoid multiple calls to this and just increment by total number of successfully sent emails inside the postman action itself.
But keeping it here is also ok, i dont think there is any material difference
a60b320 to
9a41983
Compare
fcf855e to
1741d4f
Compare
9a41983 to
ff1bad2
Compare
1741d4f to
34a472f
Compare
ff1bad2 to
a32f27a
Compare
34a472f to
0d5d0c3
Compare
a32f27a to
f020b93
Compare
9ed7d91 to
91509c9
Compare
f020b93 to
69fb6dc
Compare
91509c9 to
d903145
Compare
69fb6dc to
46fc7be
Compare
d903145 to
de10911
Compare
4d4108d to
921f21a
Compare
6cc0f29 to
f9b2bb3
Compare
921f21a to
aab629b
Compare
f9b2bb3 to
09f6135
Compare
aab629b to
97d3b6f
Compare
09f6135 to
eb4acd4
Compare
97d3b6f to
555afa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Add DogStatsD metrics tracking for SES email events (sent, bounced, complained).
WHY???
What changed?
A new
incrementMetrichelper wraps the DogStatsD tracer client to provide a reusable way to emit counter metrics. This helper is now called in three places:email-helper.tsandses-email-helper.ts), emittingses.email.sentses.email.bouncetagged withbounce_typeandbounce_sub_typeses.email.complainttagged withcomplaint_feedback_typeHow to test?
To test locally, DogStatsD writes UDP packets to
127.0.0.1:8125. Sniff withnc:# Terminal A — listen nc -ul 8125Tried testing on
uatses.email.sentmetric appears in DatadogincrementMetrichelperWhy make this change?
Visibility into SES email delivery health was limited. By tracking sent, bounce, and complaint counts as metrics in Datadog, we can monitor delivery rates, detect spikes in bounces or complaints, and set up alerts without relying solely on logs.