[EMAIL-PREVIEW-2] PLU-386: Enable RichTextEditor to substitute variables#1653
Open
ogp-weeloong wants to merge 1 commit into
Open
[EMAIL-PREVIEW-2] PLU-386: Enable RichTextEditor to substitute variables#1653ogp-weeloong wants to merge 1 commit into
ogp-weeloong wants to merge 1 commit into
Conversation
3 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label lfg to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 28, 2026
ogp-weeloong
changed the title
ogp-weeloong
changed the title
ogp-weeloong
force-pushed
the
claude/substitute-for-preview
branch
from
5f7135e to
bb896d2
Compare
ogp-weeloong
force-pushed
the
claude/email-preview-modal
branch
from
13c6512 to
ba98c73
Compare
4 tasks
substituteForPreview renders RichTextEditor HTML to plain final-form
HTML, suitable for piping into an email preview engine. Variable and
table-variable spans are replaced with their resolved value (prefer
varInfoMap lookup, fall back to the node's data-value); remaining text
nodes get simpleSubstitute applied to clean up any legacy {{step.…}}
patterns.
Unit tests cover variable spans, table-variable spans, legacy template
text, and missing-var fallback (both to data-value and to empty).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ogp-weeloong
force-pushed
the
claude/email-preview-modal
branch
from
ba98c73 to
aa87e38
Compare
ogp-weeloong
force-pushed
the
claude/substitute-for-preview
branch
from
bb896d2 to
adda098
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We want pipe owners to be able to preview their email across a variety of email clients (Outlook, Yahoo etc).
High-level Approach
See #1652 for more details.
This PR
Enables RichTextEditor to substitute variables with real values. It walks the DOM tree and:
variable/tableVariablespans with their resolved value (fromvarInfo, falling back todata-value)simpleSubstituteto any remaining text nodes to clean up legacy{{step.…}}patternsTests
Only regression tests as this is a no-op.
Full test in later PR