[EMAIL-PREVIEW-4] PLU-386: Enable email previews in appropriate previous result data#1655
Open
ogp-weeloong wants to merge 2 commits into
Open
[EMAIL-PREVIEW-4] PLU-386: Enable email previews in appropriate previous result data#1655ogp-weeloong wants to merge 2 commits into
ogp-weeloong wants to merge 2 commits into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label lfg to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ogp-weeloong
changed the base branch from
claude/email-preview-button
to
graphite-base/1655
ogp-weeloong
force-pushed
the
claude/postman-email-dataout
branch
from
5d075bc to
e1db275
Compare
ogp-weeloong
force-pushed
the
graphite-base/1655
branch
from
9996628 to
3453746
Compare
ogp-weeloong
changed the base branch from
graphite-base/1655
to
claude/preview-button-menubar
4 tasks
Widens TDataOutMetadatumType with 'email' so apps can declare a dataOut variable should be rendered through the new client-specific email preview. Switches Postman send-transactional-email's body variable from type 'html' to 'email'; the routing change in VariableItemWithModal follows in the next commit. No exhaustive switches on TDataOutMetadatumType broke, so no stub branches were needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ogp-weeloong
force-pushed
the
claude/postman-email-dataout
branch
from
e1db275 to
e192372
Compare
ogp-weeloong
force-pushed
the
claude/preview-button-menubar
branch
from
3453746 to
5a30fef
Compare
ogp-weeloong
changed the title
ogp-weeloong
changed the title
Adds an 'email' case in VariableItemWithModal that renders EmailPreviewModal with the variable's value as HTML, and includes 'email' in canOpenModal so the "View" button shows up. Registers 'email' in VARIABLES_WITH_MODALS (so the virtualized list picks VariableItemWithModal) and in VISIBLE_VARIABLE_TYPES (so the variable shows up in default rich-text suggestion lists). End-to-end this means the existing post-test "View" button on Postman's body dataOut variable now opens the new client-specific preview. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ogp-weeloong
force-pushed
the
claude/postman-email-dataout
branch
from
e192372 to
28e5cbd
Compare
kevinkim-ogp
approved these changes
Jun 8, 2026
| isOpen={isModalOpen} | ||
| onClose={onModalClose} | ||
| html={(variable.value as string) ?? ''} | ||
| title="View email" |
Contributor
There was a problem hiding this comment.
can consider getting the subject from the data out to display as the title?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We want pipe owners to be able to preview their email across a variety of email clients (Outlook, Yahoo etc).
High-level Approach
See #1652 for more details.
This PR
Updates the "View" button in "Previous Result" section to support email previews for postman's previous result email:
emailto TDataOutMetadatumTypeemail.email, so that it launches the email modal when "View" is clicked.Beedio
Screen Recording 2026-06-02 at 10.36.28 PM.mov (uploaded via Graphite)
Tests