Raise illegal instruction exception for HFENCE.VVMA/HFENCE.GVMA when in V=1 mode and rd!=0 - #3554
Open
antonangeloff wants to merge 2 commits into
Open
antonangeloff wants to merge 2 commits into
antonangeloff wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As indicated by #3462 - the
HFENCE.VVMA/HFENCE.GVMAinstructions having non-zerordbits currently trigger virtual instruction exception (mcause 22) instead of illegal instruction (mcause 2) inV=1mode.The changes in this PR make
HFENCE.*raisemcause=2exception in the above case, which is consistent with Spike. The assumption being that non-zerordbits would cause the instruction to be ill-formed (not HS-qualified).Well formed
HFENCE.*instructions are unaffected and still raise a virtual instruction exception underV=1.The test can be run via:
Related issues
Fixes #3462