DOCPLAN-170: Restructured primary udn assembly for DITA compliance#110244
DOCPLAN-170: Restructured primary udn assembly for DITA compliance#110244sjhala-ccs wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@sjhala-ccs: This pull request references DOCPLAN-170 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
sjhala-ccs
added
CNV
|
@sjhala-ccs: This pull request references DOCPLAN-170 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
sjhala-ccs
force-pushed
the
docplan-170-primary-udn
branch
from
128ee8d to
6869203
Compare
|
@sjhala-ccs: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
sjhala-ccs
changed the title
abrennan89
left a comment
abrennan89
left a comment
There was a problem hiding this comment.
Couple of minor comments / suggestions, otherwise lgtm!
| = Create a primary user-defined network by using the CLI | ||
|
|
||
| [role="_abstract"] | ||
| You can create a primary `UserDefinedNetwork` or `ClusterUserDefinedNetwork` CRD by using the CLI. After you define the custom primary overlay network, you can create namespaces that are associated with the cluster-scoped UDN. No newline at end of file |
There was a problem hiding this comment.
| You can create a primary `UserDefinedNetwork` or `ClusterUserDefinedNetwork` CRD by using the CLI. After you define the custom primary overlay network, you can create namespaces that are associated with the cluster-scoped UDN. | |
| You can create a primary `UserDefinedNetwork` or `ClusterUserDefinedNetwork` custom resource definition (CRD) by using the {oc-first}. After you define the custom primary overlay network, you can create namespaces that are associated with the cluster-scoped UDN. |
Not sure if you need to spell out CRD on first use in the module?
Also, I'd maybe specify which CLI this is referring to, e.g. use the {oc-first} attribute if it's oc
| = Create a primary user-defined network by using the web console | ||
|
|
||
| [role="_abstract"] | ||
| You can use the {product-title} web console to create a primary namespace-scoped `UserDefinedNetwork` or a cluster-scoped `ClusterUserDefinedNetwork` CRD. The UDN serves as the default primary network for pods and VMs that you create in namespaces associated with the network. |
There was a problem hiding this comment.
Same comment re CRD, not sure if we need to spell it out
4 participants
Version(s): 4.20+
Issue: https://redhat.atlassian.net/browse/DOCPLAN-170
Link to docs preview: https://110244--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-primary-udn.html
QE review: N/A
Additional information: